[PATCH dev-5.0 2/4] media: aspeed: reduce noisy log printing outs

[Eddie James]

On 4/25/19 5:20 PM, Jae Hyun Yoo wrote:
> Currently, this driver prints out too much log messages when a
> mode change happens, video turned off by screen saver and etc.
> Actually, all cases are reported to user space properly. Also,
> these are not critical errors but recoverable things, so this
> commit changes the log level of some noisy printing outs.


Reviewed-by: Eddie James <eajames at linux.ibm.com>


>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
> ---
>   drivers/media/platform/aspeed-video.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
> index 4475c6e6d0ae..429f676f9dea 100644
> --- a/drivers/media/platform/aspeed-video.c
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -441,7 +441,7 @@ static int aspeed_video_start_frame(struct aspeed_video *video)
>   
>   	if (!(seq_ctrl & VE_SEQ_CTRL_COMP_BUSY) ||
>   	    !(seq_ctrl & VE_SEQ_CTRL_CAP_BUSY)) {
> -		dev_err(video->dev, "Engine busy; don't start frame\n");
> +		dev_dbg(video->dev, "Engine busy; don't start frame\n");
>   		return -EBUSY;
>   	}
>   
> @@ -771,7 +771,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
>   						      res_check(video),
>   						      MODE_DETECT_TIMEOUT);
>   		if (!rc) {
> -			dev_err(video->dev, "Timed out; first mode detect\n");
> +			dev_dbg(video->dev, "Timed out; first mode detect\n");
>   			clear_bit(VIDEO_RES_DETECT, &video->flags);
>   			return;
>   		}
> @@ -789,7 +789,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
>   						      MODE_DETECT_TIMEOUT);
>   		clear_bit(VIDEO_RES_DETECT, &video->flags);
>   		if (!rc) {
> -			dev_err(video->dev, "Timed out; second mode detect\n");
> +			dev_dbg(video->dev, "Timed out; second mode detect\n");
>   			return;
>   		}
>   
> @@ -823,7 +823,7 @@ static void aspeed_video_get_resolution(struct aspeed_video *video)
>   	} while (invalid_resolution && (tries++ < INVALID_RESOLUTION_RETRIES));
>   
>   	if (invalid_resolution) {
> -		dev_err(video->dev, "Invalid resolution detected\n");
> +		dev_dbg(video->dev, "Invalid resolution detected\n");
>   		return;
>   	}
>   
> @@ -1471,7 +1471,7 @@ static void aspeed_video_stop_streaming(struct vb2_queue *q)
>   				!test_bit(VIDEO_FRAME_INPRG, &video->flags),
>   				STOP_TIMEOUT);
>   	if (!rc) {
> -		dev_err(video->dev, "Timed out when stopping streaming\n");
> +		dev_dbg(video->dev, "Timed out when stopping streaming\n");
>   
>   		/*
>   		 * Need to force stop any DMA and try and get HW into a good