[PATCH dev-5.0 1/4] media: aspeed: remove IRQF_SHARED flag

[Eddie James]

On 4/25/19 5:20 PM, Jae Hyun Yoo wrote:
> Video Engine has a dedicated interrupt line so this driver doesn't
> need to use IRQF_SHARED flag so remove it. Also, it'd be good for
> following what Thomas recommended in the IRQF_ONESHOT support
> patch like below:
>
> "Note that for now IRQF_ONESHOT cannot be used with IRQF_SHARED to
> avoid complex accounting mechanisms."


Reviewed-by: Eddie James <eajames at linux.ibm.com>


>
> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
> ---
>   drivers/media/platform/aspeed-video.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/aspeed-video.c b/drivers/media/platform/aspeed-video.c
> index 9da61beeef52..4475c6e6d0ae 100644
> --- a/drivers/media/platform/aspeed-video.c
> +++ b/drivers/media/platform/aspeed-video.c
> @@ -1616,8 +1616,7 @@ static int aspeed_video_init(struct aspeed_video *video)
>   	}
>   
>   	rc = devm_request_threaded_irq(dev, irq, NULL, aspeed_video_irq,
> -				       IRQF_ONESHOT | IRQF_SHARED, DEVICE_NAME,
> -				       video);
> +				       IRQF_ONESHOT, DEVICE_NAME, video);
>   	if (rc < 0) {
>   		dev_err(dev, "Unable to request IRQ %d\n", irq);
>   		return rc;