答复: [External] Re: [PATCH linux dev-5.0] [PATCH v5] ARM: dts: aspeed: Adding Lenovo Hr630 BMC

[Andrew MS1 Peng]

Hi Joel,

Sort alphabetically.
	I will revise Makefile in new patch.

Do you use this feature of the driver? If it was there as a workaround, note that the driver no longer requires a memory region if you're just using it to turn the clocks on, or point to the flash device.
	Internal discuss about reservation memory.
	
This message is cut and pasted from the aspeed-ast2500-evb.dts. Does it also apply to your system?
	I will remove the USB2.0 Virtual Hub Controller from hr630 DT. 	

Regards,
Andrew

-----邮件原件-----
发件人: Joel Stanley <joel at jms.id.au> 
发送时间: 2019年4月29日 16:00
收件人: Andrew MS1 Peng <pengms1 at lenovo.com>
抄送: OpenBMC Maillist <openbmc at lists.ozlabs.org>; Benjamin Fair <benjaminfair at google.com>; Patrick Venture <venture at google.com>; Lisa YJ19 Liu <liuyj19 at lenovo.com>; Duke KH Du <dukh at lenovo.com>; Yonghui YH21 Liu <liuyh21 at lenovo.com>; Harry Sung1 <hsung1 at lenovo.com>
主题: [External] Re: [PATCH linux dev-5.0] [PATCH v5] ARM: dts: aspeed: Adding Lenovo Hr630 BMC

On Thu, 25 Apr 2019 at 06:48, Andrew Peng <pengms1 at lenovo.com> wrote:
>
> Initial introduction of Lenovo Hr630 family equipped with Aspeed 2500 
> BMC SoC. Hr630 is a x86 server development kit with a ASPEED ast2500 
> BMC manufactured by Lenovo.
> Specifically, This adds the Hr630 platform device tree file used by 
> the Hr630 BMC machines.

Thanks for your patch. I'll wait for acks from Benjamin and Patrick before applying. I've got a a few questions of my own below.


>
> This also adds an entry of Hr630 device tree file in Makefile
>
> Signed-off-by: Andrew Peng <pengms1 at lenovo.com>
> Signed-off-by: Yonghui Liu <liuyh21 at lenovo.com>
> Signed-off-by: Lisa Liu <liuyj19 at lenovo.com>
> ---
> Changes in v5:
>  - revise pca9545 and pca9546 switch aliases name.
> Changes in v4:
>  - add pca9546 switch aliases name.
> Changes in v3:
>  - revise i2c switch aliases name.
> Changes in v2:
>  - add i2c switch aliases name.
>  - remove the unused eeprom device from DT file.
>  - remove "Licensed under..." sentence.
>
>  arch/arm/boot/dts/Makefile                    |   3 +-
>  arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dts | 890 
> ++++++++++++++++++++++++++
>  2 files changed, 892 insertions(+), 1 deletion(-)  create mode 100644 
> arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile 
> index bd40148..b5d32a0 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -1247,4 +1247,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         aspeed-bmc-opp-witherspoon.dtb \
>         aspeed-bmc-opp-zaius.dtb \
>         aspeed-bmc-portwell-neptune.dtb \
> -       aspeed-bmc-quanta-q71l.dtb
> +       aspeed-bmc-quanta-q71l.dtb \
> +       aspeed-bmc-lenovo-hr630.dtb

Sort alphabetically.

> diff --git a/arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dts 
> b/arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dts
> new file mode 100644
> index 0000000..4f18f4d
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-lenovo-hr630.dts
> @@ -0,0 +1,890 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * Device Tree file for Lenovo Hr630 platform
> + *
> + * Copyright (C) 2019-present Lenovo
> + */
> +
> +/dts-v1/;
> +
> +#include "aspeed-g5.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> +       model = "HR630 BMC";
> +       compatible = "lenovo,hr630-bmc", "aspeed,ast2500";
> +
> +       aliases {
> +               i2c14 = &i2c_rbp;
> +               i2c15 = &i2c_fbp1;
> +               i2c16 = &i2c_fbp2;
> +               i2c17 = &i2c_fbp3;
> +               i2c18 = &i2c_riser2;
> +               i2c19 = &i2c_pcie4;
> +               i2c20 = &i2c_riser1;
> +               i2c21 = &i2c_ocp;
> +       };

> +               flash_memory: region at 98000000 {
> +                       no-map;
> +                       reg = <0x98000000 0x00100000>; /* 1M */

Do you use this feature of the driver? If it was there as a workaround, note that the driver no longer requires a memory region if you're just using it to turn the clocks on, or point to the flash device.

> +               };
> +

> +/*
> + * Enable port A as device (via the virtual hub) and port B as
> + * host by default on the eval board. This can be easily changed
> + * by replacing the override below with &ehci0 { ... } to enable
> + * host on both ports.
> + */

This message is cut and pasted from the aspeed-ast2500-evb.dts. Does it also apply to your system?