[PATCH linux dev-5.0 1/1] ARM: dts: aspeed: Add s7106 BMC Machine

Joel Stanley joel at jms.id.au
Mon Apr 29 18:10:17 AEST 2019


On Tue, 23 Apr 2019 at 11:56, ray.lue <ray.lue at gmail.com> wrote:
>
>     s7106 is a Tyan platform family with an ASPEED AST2500 BMC.
>
> Signed-off-by: ray.lue <ray.lue at mic.com.tw>

The patch looks good.  Can you fix the signed off by to have your name
spelt out? I think you want to do this:

git config --global user.name "Ray Lue"
git commit --amend --reset-author -s


> @@ -1247,4 +1247,5 @@ dtb-$(CONFIG_ARCH_ASPEED) += \
>         aspeed-bmc-opp-witherspoon.dtb \
>         aspeed-bmc-opp-zaius.dtb \
>         aspeed-bmc-portwell-neptune.dtb \
> -       aspeed-bmc-quanta-q71l.dtb
> +       aspeed-bmc-quanta-q71l.dtb \
> +       aspeed-bmc-tyan-s7106.dtb

Please add your entry so it is sorted alphabetically.

> diff --git a/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> new file mode 100755
> index 0000000..b9801d1
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-tyan-s7106.dts
> @@ -0,0 +1,174 @@

You need to have a licence and copyright line.Please take a look at
another file, like

$ head -n 5 arch/arm/boot/dts/aspeed-bmc-intel-s2600wf.dts

// SPDX-License-Identifier: GPL-2.0
// Copyright (c) 2017 Intel Corporation
/dts-v1/;

#include "aspeed-g5.dtsi"

> +/dts-v1/;
> +
> +#include "aspeed-g5.dtsi"
> +
> +/ {
> +       model = "Tyan S7106 BMC";
> +       compatible = "tyan,s7106-bmc", "aspeed,ast2500";


More information about the openbmc mailing list