[PATCH] hwmon (occ): Fix extended status bits

Andrew Jeffery andrew at aj.id.au
Tue Apr 16 17:47:05 AEST 2019



On Tue, 16 Apr 2019, at 09:50, Guenter Roeck wrote:
> On Mon, Apr 15, 2019 at 06:37:20PM +0800, Lei YU wrote:
> > The occ's extended status is checked and shown as sysfs attributes. But
> > the code was incorrectly checking the "status" bits.
> > Fix it by checking the "ext_status" bits.
> > 
> > Signed-off-by: Lei YU <mine260309 at gmail.com>
> > Reviewed-by: Eddie James <eajames at linux.ibm.com>
> 
> Applied.

I've also applied this to dev-5.0.

Cheers,

Andrew

> 
> Thanks,
> Guenter
> 
> > ---
> >  drivers/hwmon/occ/sysfs.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/hwmon/occ/sysfs.c b/drivers/hwmon/occ/sysfs.c
> > index fe3d15e..a71ca94 100644
> > --- a/drivers/hwmon/occ/sysfs.c
> > +++ b/drivers/hwmon/occ/sysfs.c
> > @@ -42,16 +42,16 @@ static ssize_t occ_sysfs_show(struct device *dev,
> >  		val = !!(header->status & OCC_STAT_ACTIVE);
> >  		break;
> >  	case 2:
> > -		val = !!(header->status & OCC_EXT_STAT_DVFS_OT);
> > +		val = !!(header->ext_status & OCC_EXT_STAT_DVFS_OT);
> >  		break;
> >  	case 3:
> > -		val = !!(header->status & OCC_EXT_STAT_DVFS_POWER);
> > +		val = !!(header->ext_status & OCC_EXT_STAT_DVFS_POWER);
> >  		break;
> >  	case 4:
> > -		val = !!(header->status & OCC_EXT_STAT_MEM_THROTTLE);
> > +		val = !!(header->ext_status & OCC_EXT_STAT_MEM_THROTTLE);
> >  		break;
> >  	case 5:
> > -		val = !!(header->status & OCC_EXT_STAT_QUICK_DROP);
> > +		val = !!(header->ext_status & OCC_EXT_STAT_QUICK_DROP);
> >  		break;
> >  	case 6:
> >  		val = header->occ_state;
>


More information about the openbmc mailing list