using phosphor-dbus-monitor

[Matt Spinler]

On 4/11/2019 8:05 AM, Wim Vervoorn wrote:
> I just found filed an issue because phosphor-dbus-monitor doesn't support "double" values this is required to make it work when dbus-sensors is used.
>
> I also made 2 pull requests to resolve this.


That's great!.

Note that OpenBMC doesn't use pull requests - we do our reviews all on 
gerrit.

https://github.com/openbmc/docs/blob/master/CONTRIBUTING.md has the details.


>
> Best regards,
>
> Wim Vervoorn
>
> -----Original Message-----
> From: Lei YU [mailto:mine260309 at gmail.com]
> Sent: Thursday, April 11, 2019 2:38 PM
> To: Wim Vervoorn <wvervoorn at eltan.com>
> Cc: Matthew Barth <msbarth at linux.ibm.com>; Matt Spinler <mspinler at linux.ibm.com>; openbmc at lists.ozlabs.org
> Subject: Re: using phosphor-dbus-monitor
>
>> I just found the reason why this wasn’t working. I overlooked a typo in the interface : Sensors instead of Sensor.
> This is the sign of what needs to be improved. Either make it report error at compile time, or at least have a tool to verify the yaml.
>
>