phosphor-pid-control

James Feist james.feist at linux.intel.com
Wed Apr 3 02:44:05 AEDT 2019


On 4/2/19 5:43 AM, George Liu (刘锡伟) wrote:
> Hi, All:
> 
> Excuse me, I have a problem, 727 lines of dbus/dbusconfiguration.cpp in 
> the phosphor-pid-control code,
> 
> which I think is info.stepwiseInfo.NegativeHysteresis, as follows:
> 
> If (findPosHyst != base.end())
> 
> {
> 
> info.stepwiseInfo.positiveHysteresis = std::visit(
> 
> VariantToDoubleVisitor(), findPosHyst->second);
> 
> }
> 
> If (findNegHyst != base.end())
> 
> {
> 
> info.stepwiseInfo.positiveHysteresis = std::visit(
> 
> VariantToDoubleVisitor(), findNegHyst->second);
> 
> }
> 
> What do you think?

Good catch, fix is here: 
https://gerrit.openbmc-project.xyz/c/openbmc/phosphor-pid-control/+/20031

-James

> 
> Thanks!
> 


More information about the openbmc mailing list