[PATCH dev-5.0 v2 5/5] ARM: dts: romulus: Enable video engine

[Joel Stanley]

On Mon, 1 Apr 2019 at 15:13, Eddie James <eajames at linux.vnet.ibm.com> wrote:
>
>
> On 4/1/19 1:27 AM, Joel Stanley wrote:
> > On Fri, 29 Mar 2019 at 21:15, Eddie James <eajames at linux.ibm.com> wrote:
> >> Enable the video engine and add it's required reserved memory region.
> > The upstream bindings don't mention the reserved memory region at all.
> Whoops... I'll have to send a patch for that upstream.

Cool.

> >
> >> Signed-off-by: Eddie James <eajames at linux.ibm.com>
> >> ---
> >>   arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts | 12 ++++++++++++
> >>   1 file changed, 12 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> >> index ee1a460..54427f4 100644
> >> --- a/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> >> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts
> >> @@ -42,6 +42,13 @@
> >>                          compatible = "shared-dma-pool";
> >>                          reusable;
> >>                  };
> >> +
> >> +               ve_memory: jpegbuffer {
> > video_memory or video_engine_memory
> >
> >> +                       size = <0x04000000>;    /* 64M */
> > How do we get to 64MB?
> OK it looks like we can get away with 32MB. I hadn't run the
> calculations since the beginning of working on this driver where I was
> using a lot more memory for fixed buffers. But we do need 32MB since we
> need two source buffers of up to 1920x1200x32bpp.

Again, you need to add this information in the commit message.

I recommend putting the calculation in the commit message too.