tiny package --

Brad Bishop bradleyb at fuzziesquirrel.com
Tue Sep 11 21:45:54 AEST 2018



> On Sep 10, 2018, at 12:05 PM, Patrick Venture <venture at google.com> wrote:
> 
> On Mon, Sep 10, 2018 at 5:39 AM Brad Bishop <bradleyb at fuzziesquirrel.com> wrote:
>> 
>>> On Sep 8, 2018, at 12:01 PM, Patrick Venture <venture at google.com> wrote:
>>> 
>>> I was looking at publishing a single-header file from a package
>>> containing only that header file.  In this case, "oemgoogle.hpp" into
>>> the same place that phosphor-host-ipmid installs its headers so that
>>> any google-ipmi-* packages could store their OEM numbers in one file
>>> (upstream).
>> 
>> Why is the number hardcoded at all?  Could it be a configure option or
>> command line option?
> 
> I could definitely add the number to each daemon or library, however
> having a single source of the numbers is valuable to avoid accidental
> collisions.

Agree to disagree I guess.  You could define it once in your layer and
be done…

> 
>> 
>> If those don’t work, as a fall-back can we just put the header in the
>> upstream phosphor-host-ipmid repository as you’ve done downstream?
> 
> I started with this approach and it was rejected by the maintainers,
> because the numbers reserved for Google code (even shared upstream)
> "didn't belong" in phosphor-host-ipmid.

I think we should push back on this.


More information about the openbmc mailing list