bradleyb at fuzziesquirrel.com
Wed Sep 5 09:42:18 AEST 2018
> On Sep 4, 2018, at 7:18 PM, Ed Tanous <ed.tanous at intel.com> wrote:
> On 09/04/2018 03:34 PM, Brad Bishop wrote:
>> ok, then this is my ignorance of IPMI showing. I thought IPMI_SEL_SENSOR_PATH was
>> an IPMI construct...
>> If this is the case then why not just call it SENSOR_PATH? Then other logging formats
>> could use that metadata key without it being weird that it has ‘ipmi_sel’ in the name
>> of it. And can we apply the same logic to the other keys or do some of the other keys
>> have more complicated translation logic (than none at all as in the case of the sensor
>> path) ?
> The thinking was that we would namespace all the parameters using IPMI_SEL to make it clear that was the only place they were used, and to avoid someone else using it inadvertently.
> With that said, I could understand how it could be confusing. Jason, any objections to un-namespacing the parameters?
Thanks for being flexible on this but lets wait until we are on the same page before
changing anything. Why would you want to discourage it from being used in another
>> Thats great! This is similar to how the phosphor-logging daemon creates dbus error
>> objects today.
>> Would you mind elaborating on this daemon and its dbus API? I’m guessing it would probably
>> clear up any concerns I have.
> Patches to phosphor-dbus-interfaces for a suggested interface are being put together as we speak. Hopefully that will clarify it a little bit.
Great, thank you.
>>> While technically it could be a part of phosphor-logging,
>> That isn’t what I was going for. If you plan to implement a (separate) daemon that acts on
>> the journald metadata I think that is right approach too.
>>> we really want it to be easily removable for future platforms that have no need for IPMI, so the thought at this time it to keep it separate.
>>>> Further, if you expand this approach to further log formats other than SEL,
>>>> won’t the applications become a mess of translation logic from the applications
>>>> data mode <-> log format in use?
>>> I'm not really following this question. Are there other binary log formats that we expect to come in the future that aren't text based, and could just be a journald translation?
>> Yes. We have a binary format called PEL. I doubt anyone would be interested in using
>> it but we need a foundation in OpenBMC that enables us to use it...
> That makes more sense now. A quick google on PEL makes it look like it could follow a similar model to what we're doing with IPMI by adding the extra metadata to journald when needed, while still producing the string versions for the basic cases. By foundation do you mean shared code? A quick skim of the implementation makes me suspect that there isn't going to be a lot of shared code, although they could share a similar design with a different implementation.
By foundation I simply mean we need a way to support multiple logging formats that doesn’t
require every OpenBMC application to know how to translate from its internal data model
(usually dbus) to N logging formats.
>>> So far as I know, IPMI SEL is the only one on my road map that has weird requirements, and needs some translation.
>> Where is the translation happening? In the new ipmi-sel daemon? Or somewhere else?
> The translation would happen on the "addSel" IPMI command that gets used in-band by most BIOS implementations. The ipmi-sel daemon will translate the raw bytes to a string, to be used in most modern loggers, along with the IPMI metadata, to be used in IPMI to source the various "get" SEL entry commands.
That all sounds fine. But what about applications on the BMC creating SELs for their
own errors? Do you want to do that? How will that work?
>>> I don't expect it to be a mess, and I'm running under the assumption that _most_ daemons won't care about or support IPMI given its limitations.
>> Well _all_ daemons already support IPMI SEL today. The problem is just that the
>> implementation doesn’t scale. I’m confused by _most_ daemons wouldn’t support
> That should've clarified that most daemons won't care about IPMI _SEL_, given the extra calls and metadata that needs to be provided to implement it correctly. My teams intention was to support the minimum subset of SEL that we can for backward compatibility, while providing the advanced logging (journald/syslog/redfish LogService) for a greater level of detail and capability.
> If this assumption turns out to not be true, and we end up adding IPMI SEL logging to all the daemons, so be it, I think it will still scale, but I really hope that's not the path we go down.
Oh. Does this mean you intend for code like Jason originally proposed to _only_ appear in
the ipmi-sel daemon? And not in applications like phosphor-hwmon?
More information about the openbmc