[oe] [meta-python][PATCH v2 1/3] meta-python: Add python-pyflame recipe

Khem Raj raj.khem at gmail.com
Wed Sep 5 04:51:06 AEST 2018


On Tue, Sep 4, 2018 at 2:38 AM Martin Jansa <martin.jansa at gmail.com> wrote:
>
> Hi,
>
> it also fails for aarch64:
>
> | ../../git/src/ptrace.cc: In function 'user_regs_struct pyflame::PtraceGetRegs(pid_t)':
> | ../../git/src/ptrace.cc:127:14: error: 'PTRACE_GETREGS' was not declared in this scope
> |    if (ptrace(PTRACE_GETREGS, pid, 0, &regs)) {
> |               ^~~~~~~~~~~~~~
> | ../../git/src/ptrace.cc:127:14: note: suggested alternative: 'PTRACE_GETREGSET'
> |    if (ptrace(PTRACE_GETREGS, pid, 0, &regs)) {
> |               ^~~~~~~~~~~~~~
> |               PTRACE_GETREGSET
> | ../../git/src/ptrace.cc: In function 'void pyflame::PtraceSetRegs(pid_t, user_regs_struct)':
> | ../../git/src/ptrace.cc:136:14: error: 'PTRACE_SETREGS' was not declared in this scope
> |    if (ptrace(PTRACE_SETREGS, pid, 0, &regs)) {
> |               ^~~~~~~~~~~~~~
> | ../../git/src/ptrace.cc:136:14: note: suggested alternative: 'PTRACE_SETREGSET'
> |    if (ptrace(PTRACE_SETREGS, pid, 0, &regs)) {
> |               ^~~~~~~~~~~~~~
> |               PTRACE_SETREGSET
> | Makefile:524: recipe for target 'ptrace.o' failed
> | make[2]: *** [ptrace.o] Error 1
>
> I don't plan to use it, so I'm ok with aarch64 removal from compatible archs if the fix turns to be complicated.
>

Lets exclude it if it does not build. Care to send a patch ?

> Cheers,
>
> On Thu, May 31, 2018 at 6:49 PM Khem Raj <raj.khem at gmail.com> wrote:
>>
>> fails to build on qemumips
>>
>> | ../../git/src/ptrace.cc: In function 'user_regs_struct
>> pyflame::PtraceGetRegs(pid_t)':
>> | ../../git/src/ptrace.cc:125:41: error: return type 'user_regs_struct
>> {aka struct user_regs_struct}' is incomplete
>> |  user_regs_struct PtraceGetRegs(pid_t pid) {
>> |                                          ^
>> | ../../git/src/ptrace.cc:125:18: error: ambiguating new declaration
>> of 'void pyflame::PtraceGetRegs(pid_t)'
>> |  user_regs_struct PtraceGetRegs(pid_t pid) {
>> |                   ^~~~~~~~~~~~~
>> | In file included from ../../git/src/ptrace.cc:15:0:
>> | ../../git/src/./ptrace.h:48:18: note: old declaration
>> 'user_regs_struct pyflame::PtraceGetRegs(pid_t)'
>> |  user_regs_struct PtraceGetRegs(pid_t pid);
>> |                   ^~~~~~~~~~~~~
>> | ../../git/src/ptrace.cc:126:20: error: aggregate 'user_regs_struct
>> regs' has incomplete type and cannot be defined
>> |    user_regs_struct regs;
>> |                     ^~~~
>> | ../../git/src/ptrace.cc: In function 'void
>> pyflame::PtraceSetRegs(pid_t, user_regs_struct)':
>> | ../../git/src/ptrace.cc:135:48: error: 'regs' has incomplete type
>> |  void PtraceSetRegs(pid_t pid, user_regs_struct regs) {
>> |                                                 ^~~~
>> | In file included from ../../git/src/ptrace.cc:15:0:
>> | ../../git/src/./ptrace.h:29:16: note: forward declaration of
>> 'user_regs_struct {aka struct user_regs_struct}'
>> |  typedef struct user_regs_struct user_regs_struct;
>> |                 ^~~~~~~~~~~~~~~~
>> | make[2]: *** [ptrace.o] Error 1
>> | make[2]: *** Waiting for unfinished jobs....
>> | make[2]: Leaving directory
>> `/mnt/jenkins/workspace/OpenEmbedded/build/tmp/work/mips32r2-bec-linux/python-pyflame/1.6.6-r0/build/src'
>>
>> On Tue, May 29, 2018 at 4:48 AM, Andrew Jeffery <andrew at aj.id.au> wrote:
>> > On Thu, 10 May 2018, at 16:07, Andrew Jeffery wrote:
>> >> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
>> >
>> > Ping - is there anything I need to revise for this patch or the following two?
>> >
>> > Cheers,
>> >
>> > Andrew
>> >
>> >> ---
>> >>  meta-python/recipes-devtools/python/python-pyflame.inc      | 12 ++++++++++++
>> >>  meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb |  1 +
>> >>  2 files changed, 13 insertions(+)
>> >>  create mode 100644 meta-python/recipes-devtools/python/python-pyflame.inc
>> >>  create mode 100644 meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
>> >>
>> >> diff --git a/meta-python/recipes-devtools/python/python-pyflame.inc b/
>> >> meta-python/recipes-devtools/python/python-pyflame.inc
>> >> new file mode 100644
>> >> index 000000000000..3b84a7e8f8e3
>> >> --- /dev/null
>> >> +++ b/meta-python/recipes-devtools/python/python-pyflame.inc
>> >> @@ -0,0 +1,12 @@
>> >> +SUMMARY = "Pyflame: A Ptracing Profiler For Python"
>> >> +HOMEPAGE = "https://github.com/uber/pyflame"
>> >> +SECTION = "devel/python"
>> >> +LICENSE = "Apache-2.0"
>> >> +LIC_FILES_CHKSUM = "file://${S}/
>> >> LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
>> >> +DEPENDS = "python"
>> >> +
>> >> +SRC_URI = "git://github.com/uber/pyflame.git;protocol=https;tag=v${PV}"
>> >> +S = "${WORKDIR}/git"
>> >> +
>> >> +inherit pkgconfig autotools
>> >> +
>> >> diff --git a/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
>> >> b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
>> >> new file mode 100644
>> >> index 000000000000..96f03305f883
>> >> --- /dev/null
>> >> +++ b/meta-python/recipes-devtools/python/python-pyflame_1.6.6.bb
>> >> @@ -0,0 +1 @@
>> >> +require python-pyflame.inc
>> >> --
>> >> 2.14.1
>> >>
>> > --
>> > _______________________________________________
>> > Openembedded-devel mailing list
>> > Openembedded-devel at lists.openembedded.org
>> > http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel


More information about the openbmc mailing list