[PATCH v8 07/12] dt-bindings: mfd: Add a document for PECI client MFD

Jae Hyun Yoo jae.hyun.yoo at linux.intel.com
Thu Oct 25 03:39:51 AEDT 2018


Hi Lee,

On 10/24/2018 12:25 AM, Lee Jones wrote:
> On Tue, 18 Sep 2018, Jae Hyun Yoo wrote:
> 
>> +Required properties:
>> +- compatible : Should be "intel,peci-client".
>> +- reg        : Should contain address of a client CPU. Address range of CPU
>> +	       clients starts from 0x30 based on PECI specification.
> 
> Nit: "start"
> 
> Would be better worded:
> 
> "According to the PECI specification client addresses start from 0x30."
> 

Yes, that would be better. Will fix it like you suggested.

Thanks for the review!

Jae


More information about the openbmc mailing list