fru inventory update

[Vijay Khemka]

On 10/20/18, 9:05 AM, "Patrick Venture" <venture at google.com> wrote:

    On Fri, Oct 19, 2018 at 4:41 PM Vijay Khemka <vijaykhemka at fb.com> wrote:
    >
    > Hi,
    >
    > I am trying to read fru data of my board and created a config.yaml. I noticed few things that there is only 5 field updated in system/xyz.openbmc_project.Inventory.Decorator.Asset even though I have more field requested in config file. And also how do I get meaningful key string instead of value0, value1. Please see below config.yaml and inventory file.
    >
    >
    >
    > Config.yaml
    >
    > ============
    >
    >   /system:
    >
    >     entityID: 3
    >
    >     entityInstance: 1
    >
    >     interfaces:
    >
    >       xyz.openbmc_project.Inventory.Decorator.Asset:
    >
    >         SerialNumber:
    >
    >           IPMIFruProperty: Serial Number
    >
    >           IPMIFruSection: Product
    >
    >         Manufacturer:
    >
    >           IPMIFruProperty: Manufacturer
    >
    >           IPMIFruSection: Product
    >
    >         Model:
    >
    >           IPMIFruProperty: Model Number
    >
    >           IPMIFruSection: Product
    >
    >         PrettyName:
    >
    >           IPMIFruProperty: Name
    >
    >           IPMIFruSection: Product
    >
    >         Version:
    >
    >           IPMIFruProperty: Version
    >
    >           IPMIFruSection: Product
    >
    >         AssetTag:
    >
    >           IPMIFruProperty: Asset Tag
    >
    >           IPMIFruSection: Product
    >
    >         CustomField1:
    >
    >           IPMIFruProperty: Custom Field 1
    >
    >           IPMIFruSection: Product
    >
    >         CustomField2:
    >
    >           IPMIFruProperty: Custom Field 2
    >
    >           IPMIFruSection: Product
    >
    >
    >
    >
    >
    > system/xyz.openbmc_project.Inventory.Decorator.Asset
    >
    > ====================================================
    >
    > {
    >
    >     "value0": {
    >
    >         "cereal_class_version": 1,
    >
    >         "value0": "",
    >
    >         "value1": "WTF17370D2MA1",
    >
    >         "value2": "Wiwynn",
    >
    >         "value3": "",
    >
    >         "value4": "B81.00X01.0104"
    >
    >     }
    >
    > }
    >
    >
    >
    >
    >
    > Please advise here as what am I missing.
    
    It's my understanding that the FruSection field matters, and if it
    doesn't match it won't populate that aspect of it.  Yours are set to
    "Product" everywhere, however, perhaps they should be "Board" or
    something else, that indicate different sections.
  I have different sections for different field and I have those for Board and chassis as well.
  I see same issue for Board and chassis. As it doesn't output more than 5 values. And I feel
  We should have proper key rather value0, value1, .. 
    >
    >
    >
    > Regards
    >
    > -Vijay