[PATCH v2] hwmon: (adm1275): Add device tree param for shunt resistor

Rob Herring robh at kernel.org
Sat Oct 13 07:11:28 AEDT 2018


On Fri, Sep 28, 2018 at 12:58:00PM -0700, Kun Yi wrote:
> The ADM series of hotswap controllers support extending
> the current measurement range by using a sensing resistor
> value other than the typical 1 mOhm. For example, using a 0.5 mOhm
> sensing resistor doubles the maximal current can be measured.
> 
> Current driver assumes a shunt resistor value of 1 mOhm in calculation,
> meaning for other resistor values, hwmon will report scaled
> current/power measurements. This patch adds a device tree parameter so
> that individual boards can configure its shunt resistor value.
> 
> Signed-off-by: Kun Yi <kunyi at google.com>
> ---
>  .../devicetree/bindings/hwmon/adm1275.txt     | 25 +++++++++++++++++++

This should be a separate patch. In particular, the subject doesn't 
really reflect that you are adding a new binding.

Otherwise, the binding looks fine.

>  Documentation/hwmon/adm1275                   |  3 +++
>  drivers/hwmon/pmbus/adm1275.c                 | 15 +++++++++--
>  3 files changed, 41 insertions(+), 2 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt


More information about the openbmc mailing list