[PATCH] watchdog: core: suppress "watchdog did not stop" message

Tao Ren taoren at fb.com
Fri Nov 16 10:44:26 AEDT 2018

Currently "watchdog did not stop!" message is printed when the watchdog
timer is not stopped at close. For example, people may see the message
when rebooting the system, or the message will be logged to console
periodically if watchdog is kicked by a scirpt which runs "echo k >
/dev/watchdog" command.

Given a critical message usually indicates a serious hardware/software
failure, this message could easily lead to confusion, so it's better to
just delete the message.

Signed-off-by: Tao Ren <taoren at fb.com>
 drivers/watchdog/watchdog_dev.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c
index f6c24b22b37c..65e9ebbd8759 100644
--- a/drivers/watchdog/watchdog_dev.c
+++ b/drivers/watchdog/watchdog_dev.c
@@ -879,7 +879,6 @@ static int watchdog_release(struct inode *inode, struct file *file)
 	/* If the watchdog was not stopped, send a keepalive ping */
 	if (err < 0) {
-		pr_crit("watchdog%d: watchdog did not stop!\n", wdd->id);

More information about the openbmc mailing list