[PATCH v2 1/2] ARM: dts: Add Facebook BMC flash layout

Tao Ren taoren at fb.com
Thu Nov 8 13:31:32 AEDT 2018

On 11/7/18 5:45 PM, Andrew Jeffery wrote:

>>> Is this necessary? Isn't the same thing achieved with the /dev/mtd0 device?
>> Hi Andrew,
>> Thank you for the review! The new layout file is needed mainly because 
>> of "data0" partition: several facebook platforms use the partition as 
>> "persistent" storage.
>> As for "flash0", technically it's not needed (as you pointed out, /dev/
>> mtd0 covers the entire flash if master_partition is enabled). It's still 
>> here to avoid breaking some legacy applications.
> This is what I expected. I think it might be worth adding a comment, given
> you are respinning the series to address my comments on the board
> devicetree patch.
> Anyway, thanks for the clarification.
> Andrew

Sure Andrew. I will add some comments and send out 2 updated patches together (most likely sometime tomorrow).

Tao Ren

More information about the openbmc mailing list