[PATCH linux dev-4.13 2/4] fsi/occ: Add Retries on checksum errors

Benjamin Herrenschmidt benh at kernel.crashing.org
Tue May 22 10:36:49 AEST 2018


On Mon, 2018-05-21 at 13:58 -0500, Eddie James wrote:
> > >    If it's the former then retrying independent of the OCC error
> > > handling protocol is probably okay, but if we're trying to catch the
> > > latter then maybe we should let this be handled as part of the OCC
> > > error handling code?
> > > 
> > > Eddie?
> 
> The checksum is part of the OCC response, so it's not a transport thing. 
> If we've gotten to checking the checksum then we've got a full response 
> that looks valid so far (reasonable length, etc).
> 
> If we're trying to adhere to the OCC spec, then I'm of the opinion that 
> we shouldn't do any retries except for those handled in the occ-hwmon 
> driver.

I don't see any in there ... what am I missing ?

Cheers,
Ben.



More information about the openbmc mailing list