[RFC PATCH linux dev-4.13 1/3] soc: aspeed: Miscellaneous control interfaces

Andrew Jeffery andrew at aj.id.au
Fri May 11 10:43:14 AEST 2018


On Fri, 11 May 2018, at 04:09, Eugene.Cho at dell.com wrote:
> Hey Andrew - 
> 
> > Have you played with the implementation at all? Would be good to get some consensus on it being a decent approach here before we go upstream with it. I also need to add devicetree bindings and ABI documentation...
> 
> Yea we have a "Dell" driver which almost matches exactly aspeed-bmc-
> misc.c (sysfs node per register field...  label,reg-offset, and bit-mask 
> configured via dt). 
> I think what you got is good, only thing I would say is maybe remove the 
> references to aspeed?
> 

Yeah, I'll rework the patches to file-off the ASPEED parts and find a more appropriate home for the driver.

Cheers for the feedback.

Andrew


More information about the openbmc mailing list