[PATCH linux dev-4.13 1/6] gpio/aspeed: Set output latch before changing direction

[Joel Stanley]

On 10 May 2018 at 12:20, Andrew Jeffery <andrew at aj.id.au> wrote:
> On Wed, 9 May 2018, at 01:43, Christopher Bostic wrote:
>> Reviewed-by: Christopher Bostic <cbostic at linux.vnet.ibm.com>
>>
>>
>> On 5/7/18 8:06 PM, Benjamin Herrenschmidt wrote:
>> > In aspeed_gpio_dir_out(), we need to establish the new output
>> > value in the output latch *before* we change the direction
>> > to output in order to avoid a glitch on the output line if
>> > the previous value of the latch was different.
>> >
>
> I think Milton mentioned this in a review way back when I was upstreaming the driver, but looks like I forgot to address it.
>
>> > Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
>
> Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

Ben, can you please send this upstream as a fix?

Cheers,

Joel