[PATCH linux dev-4.13 4/6] fsi/fsi-master-gpio: Add "no-gpio-delays" option

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu May 10 13:10:45 AEST 2018


On Thu, 2018-05-10 at 12:33 +0930, Andrew Jeffery wrote:
> > >      for (i = 0; i < count; i++) {
> > > -           ndelay(FSI_GPIO_STD_DLY);
> > > +           if (!master->no_delays)
> 
> This is a bit of a nit, but we don't have to have the member name
> reflect the devicetree property. I reckon the code would be mildly
> easier to read (avoiding the double-negative) if we inverted it:
> 
>                         if (master->do_delays)
>  
> > > +                   ndelay(FSI_GPIO_STD_DLY);

I prefer it as "no_delays" personally because delays is the norm,
and no delays is the exception for aspeed (or slow GPIO blocks).

Cheers,
Ben.



More information about the openbmc mailing list