[PATCH linux dev-4.13] ARM: dts: aspeed: Move random number device

[Andrew Jeffery]

On Fri, 4 May 2018, at 12:13, Joel Stanley wrote:
> Move the node out from under the syscon/simple-mfd.
> 
> Being a child of this node causes the driver to fail to probe, as
> platform_get_resource returns NULL due to dev->num_resources being zero.

Ugh. I'm frustrated by the schism that simple-mfd/syscon introduces. It looks like such an attractive solution right up until its not, when you have existing drivers like this that you want to plug into MMIO space already covered by the syscon/simple-mfd.

Do we have a way out of this kind of mess?

What about adding regmap support to the timeriomem_rng driver?

> 
> Signed-off-by: Joel Stanley <joel at jms.id.au>
> ---
>  arch/arm/boot/dts/aspeed-g4.dtsi | 12 ++++++------
>  arch/arm/boot/dts/aspeed-g5.dtsi | 12 ++++++------
>  2 files changed, 12 insertions(+), 12 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
> index 3d391b428b25..50bc661b8fff 100644
> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
> @@ -120,13 +120,13 @@
>  				pinctrl: pinctrl {
>  					compatible = "aspeed,g4-pinctrl";
>  				};
> +			};
>  
> -				hwrng at 78 {
> -					compatible = "timeriomem_rng";
> -					reg = <0x78 0x4>;
> -					period = <1>;
> -					quality = <100>;
> -				};
> +			rng: hwrng at 78 {
> +				compatible = "timeriomem_rng";
> +				reg = <0x78 0x4>;
> +				period = <1>;
> +				quality = <100>;
>  			};
>  
>  			adc: adc at 1e6e9000 {
> diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi
> index 01b66359e6d6..e9e039a6407c 100644
> --- a/arch/arm/boot/dts/aspeed-g5.dtsi
> +++ b/arch/arm/boot/dts/aspeed-g5.dtsi
> @@ -161,13 +161,13 @@
>  				vga_scratch: scratch {
>  					compatible = "aspeed,bmc-misc";
>  				};
> +			};
>  
> -				hwrng at 78 {
> -					compatible = "timeriomem_rng";
> -					reg = <0x78 0x4>;
> -					period = <1>;
> -					quality = <100>;
> -				};
> +			rng: hwrng at 78 {
> +				compatible = "timeriomem_rng";
> +				reg = <0x78 0x4>;
> +				period = <1>;
> +				quality = <100>;
>  			};
>  
>  			gfx: display at 1e6e6000 {
> -- 
> 2.17.0
>