[PATCH linux dev-4.13] ARM: dts: aspeed: Add Portwell Neptune machine

[Joel Stanley]

On 23 March 2018 at 11:22, Amithash Prasad <amithash at fb.com> wrote:

> +++ b/arch/arm/boot/dts/aspeed-bmc-portwell-neptune.dts
> @@ -0,0 +1,158 @@
> +// SPDX-License-Identifier: GPL-2.0
> +// Copyright (c) 2017 Facebook Inc.
> +/dts-v1/;
> +
> +#include "aspeed-g5.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> +       model = "Portwell Neptune BMC";
> +       compatible = "portwell,neptune-bmc", "aspeed,ast2500";
> +       aliases {
> +               serial0 = &uart1;
> +               serial4 = &uart5;
> +       };

These are redundant; they are included in aspeed-g5.dtsi.

> +&mac0 {
> +       status = "okay";
> +
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rmii1_default>;
> +};
> +
> +&mac1 {
> +       status = "okay";
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_rgmii2_default>;
> +       use-ncsi;

NCSI can only be used with RMII as far as I understand.

If this is supposed to be NCSI, you need to mux pinctrl_rmii2_default.

If it's supposed to be RGMII, you need to mux pinctrl_rgmii2_default
and pinctrl_mdio2_default.

Cheers,

Joel