[PATCH linux dev-4.10] ARM: dts: aspeed: Add Portwell Neptune machine

Amithash Prasad amithash at fb.com
Fri Mar 16 05:24:41 AEDT 2018


> I like to have a sentence about the machine it's in. Something like: 
> Neptune is a x86 server development kit with a ASPEED ast2500 BMC
>    manufactured by Portwell.
Roger that! Will send out an update with more information.

>> +&wdt2 {
>> +       status = "okay";
>> +};    
>>
>    We can drop this; the upstream dts now enables wdt1 and wdt2 by default.
I notice that 4.13 has this but 4.10 does not. How about have this for
The 4.10 branch (Since the openbmc distro defaults to 4.10) and the cherry-pick
to 4.13 (the upstream candidate) should drop it.

>> +&uart1 {
>> +       // Host Console
>> +       status = "okay";
>>    
>    I think you need the pinctrl nodes for this. Andrew J can provide more detail.

Thanks! Yes, I seem to be missing
+       pinctrl-names = "default";
+       pinctrl-0 = <&pinctrl_txd1_default
+                    &pinctrl_rxd1_default>;
(From inspecting the schematic, there seems to be just two pins hooked up).
I will include this in V2.



More information about the openbmc mailing list