[PATCH linux dev-4.17 v2 1/2] ARM: dts: aspeed: Add "spi-max-frequency" property

Joel Stanley joel at jms.id.au
Mon Jun 25 15:01:35 AEST 2018


On 25 June 2018 at 14:23, Cédric Le Goater <clg at kaod.org> wrote:
> On 06/25/2018 05:40 AM, Joel Stanley wrote:
>> Hi Cedric,
>>
>> On 22 June 2018 at 16:39, Cédric Le Goater <clg at kaod.org> wrote:
>>> Keep the FMC controller chips at a safe 50 MHz rate and use 100 MHz
>>> for the PNOR on the machines using a AST2500 SoC.
>>>
>>> Signed-off-by: Cédric Le Goater <clg at kaod.org>
>>> ---
>>>  arch/arm/boot/dts/aspeed-ast2500-evb.dts         | 2 ++
>>>  arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts    | 2 ++
>>>  arch/arm/boot/dts/aspeed-bmc-opp-romulus.dts     | 2 ++
>>>  arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 3 +++
>>>  arch/arm/boot/dts/aspeed-bmc-opp-zaius.dts       | 2 ++
>>
>> The changes look good. I notice you've only modified the openpower
>> platforms and the evb. Is there a reason we don't do this for all of
>> the ast2500 boards?
>
> When I started working on this patchset, I am not sure these boards
> existed yet. Should we just bump the max freq to 100MHz for all ?

Yes, I think that's a good option.

What are they symptoms when the speed is increased too much?


More information about the openbmc mailing list