[PATCH v7 11/12] hwmon: Add PECI dimmtemp driver
Jae Hyun Yoo
jae.hyun.yoo at linux.intel.com
Tue Jul 31 08:45:05 AEST 2018
Hi Rob,
On 7/30/2018 3:06 PM, Rob Herring wrote:
> On Mon, Jul 23, 2018 at 3:49 PM Jae Hyun Yoo
> <jae.hyun.yoo at linux.intel.com> wrote:
>>
>> This commit adds PECI dimmtemp hwmon driver.
>>
>
>> +#if IS_ENABLED(CONFIG_OF)
>> +static const struct of_device_id peci_dimmtemp_of_table[] = {
>> + { .compatible = "intel,peci-dimmtemp" },
>> + { }
>> +};
>> +MODULE_DEVICE_TABLE(of, peci_dimmtemp_of_table);
>> +#endif
>
> This should be removed. Same for cpu temp driver I'm guessing.
>
Yes, you are right. This isn't needed anymore because MFD driver
loads this module. I'll remove this code from here and from cpu temp
driver. Also, I'll remove 'of_compatible' setting of 'struct mfd_cell
peci_functions' in intel-peci-client.c code.
Thanks a lot for your pointing it out!
Jae
> Rob
>
More information about the openbmc
mailing list