[PATCH linux dev-4.13 01/16] dts: fsi: Make OCC description match expected hierarchy

Eddie James eajames at linux.vnet.ibm.com
Fri Feb 23 07:25:46 AEDT 2018



On 02/19/2018 10:18 PM, Andrew Jeffery wrote:
> ibm,p9-occ-hwmon describes a driver, not hardware, but this compatible is
> what's required to get the driver to probe.
>
> While we discuss how to resolve that problem, lets at least make the current
> configuration work.

I already have a possible solution in my patch "drivers: occ: Create 
hwmon platform device directly"
that does away with dts entries for the hwmon driver. Open to feedback, 
but it will obviously conflict with this patch.

Thanks,
Eddie

>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> ---
>   arch/arm/boot/dts/ibm-power9-cfam.dtsi | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/ibm-power9-cfam.dtsi b/arch/arm/boot/dts/ibm-power9-cfam.dtsi
> index e0e738f9e539..215cc8182ca5 100644
> --- a/arch/arm/boot/dts/ibm-power9-cfam.dtsi
> +++ b/arch/arm/boot/dts/ibm-power9-cfam.dtsi
> @@ -113,8 +113,12 @@
>   			#size-cells = <0>;
>
>   			occ at 1 {
> -				compatible = "ibm,p9-occ-hwmon";
> +				compatible = "ibm,p9-occ";
>   				reg = <1>;
> +
> +				occ-hwmon at 1 {
> +					compatible = "ibm,p9-occ-hwmon";
> +				};
>   			};
>   		};
>
> @@ -205,8 +209,12 @@
>   					#size-cells = <0>;
>
>   					occ at 2 {
> -						compatible = "ibm,p9-occ-hwmon";
> +						compatible = "ibm,p9-occ";
>   						reg = <2>;
> +
> +						occ-hwmon at 2 {
> +							compatible = "ibm,p9-occ-hwmon";
> +						};
>   					};
>   				};
>   			};



More information about the openbmc mailing list