[PATCH linux dev-4.13 v6] Add ARM system BMC device tree

Joel Stanley joel at jms.id.au
Thu Feb 22 17:40:54 AEDT 2018


Hi Ken,

On Wed, Feb 21, 2018 at 5:47 PM, Ken Chen <chen.kenyy at inventec.com> wrote:
> +&i2c8 {
> +       status = "okay";
> +
> +       pca9641 at 70 {
> +               compatible = "nxp,pca9641";
> +               reg = <0x70>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;

In order to build cleanly, I had to move the above two lines into the
i2c-arb node.

It is important that you compile your patches before submitting them,
and that they do not introduce any new warnings to the build.

I have fixed this for you in this case.

> +               i2c-arb {
> +                       tmp421 at 1d {
> +                               compatible = "tmp421";
> +                               reg = <0x1d>;
> +                       };
> +                       adm1278 at 12 {
> +                               compatible = "adi,adm1278";
> +                               reg = <0x12>;
> +                               Rsense = <500>;
> +                       };
> +                       eeprom at 50 {
> +                               compatible = "atmel,24c02";
> +                               reg = <0x50>;
> +                       };
> +                       ds1100 at 58 {
> +                               compatible = "ds1100";
> +                               reg = <0x58>;
> +                       };
> +               };
> +       };
> +};
> +

> +&wdt2 {
> +       status = "okay";
> +};

This is redundant in dev-4.13.

I've fixed up these minor errors and applied it to dev-4.13.
Congratulations for your persistence :)

Cheers,

Joel


More information about the openbmc mailing list