[PATCH linux dev-4.13 v5] Add ARM system BMC device tree

[Joel Stanley]

Hi Ken,

On Mon, Feb 12, 2018 at 10:40 PM, Ken Chen <chen.kenyy at inventec.com> wrote:
> Centriq2400-rep is ARM system reference evalutiion platform
> with ast2520 BMC.

How about:

The Qualcomm Centriq 2400 REP (Reference Evaluation Platform) is
aarch64 Armv8 server platform with an ast2520 BMC.


>
> Signed-off-by: Ken Chen <chen.kenyy at inventec.com>
>
> ---
> v4->v5
> - Removed strange whitespace
> - Removed aspeed.c commit
> - Modify commit content
>
> v3->v4
> - Modify Makefile for centriq2400-rep dts
> - Fix typo label
> - Removed unnecessary define of spi2 and centriq2400-spi-hwmon device
> - Removed lpc device
> - Fix coding style
> - Removed ssif device
> - Removed max31790 device
> - Removed register control of GPIO and Watchdog
> ---
>  arch/arm/boot/dts/Makefile                         |   1 +
>  .../boot/dts/aspeed-bmc-arm-centriq2400-rep.dts    | 276 +++++++++++++++++++++
>  2 files changed, 277 insertions(+)
>  create mode 100644 arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 7c54fc8..77aef19 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -993,6 +993,7 @@ dtb-$(CONFIG_ARCH_ASPEED) += aspeed-bmc-opp-palmetto.dtb \
>         aspeed-bmc-mellanox-msn.dtb \
>         aspeed-bmc-quanta-q71l.dtb \
>         aspeed-bmc-intel-s2600wf.dtb \
> +        aspeed-bmc-arm-centriq2400-rep.dtb \

Nit: we keep these in alphabetical order.

I notice that this patch is against the 4.10 branch. Please rebase
your patch on dev-4.13.

>         aspeed-ast2500-evb.dtb
>  endif
>

> +&gpio {
> +       pin_gpio_c7 {
> +               gpio-hog;
> +               gpios = <ASPEED_GPIO(C, 7) GPIO_ACTIVE_HIGH>;
> +               output;
> +               line-name = "BIOS_SPI_MUX_S";
> +       };
> +}

Have you built and booted a kernel using this device tree?

I get an error when building:

Error: arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts:276.2-277.1
syntax error
FATAL ERROR: Unable to parse input tree

Please fix up the missing semicolon, do a build, and ensure this boots
on your system.

When you send v5 you can add the Acked-by line from Andrew to your
commit message.

Cheers,

Joel