[PATCH u-boot v2016.07-aspeed-openbmc] aspeed: un-hardcode FIT configuration selection

Rick Altherr raltherr at google.com
Wed Feb 14 04:58:39 AEDT 2018


SGTM

On Mon, Feb 12, 2018 at 8:03 PM, Brad Bishop <bradleyb at fuzziesquirrel.com>
wrote:

>
> > On Feb 12, 2018, at 10:58 PM, Joel Stanley <joel at jms.id.au> wrote:
> >
> > On Fri, Feb 2, 2018 at 1:37 PM, Brad Bishop <bradleyb at fuzziesquirrel.com>
> wrote:
> >> Rely on the FDT parser to select a FIT config when looking for a
> >> ramdisk_conf.  This allows image builders to use arbitrary configuration
> >> names like /configurations/conf at foo.
> >
> > Can you elaborate?
> >
> > Do we even need this script? IIRC it was in place to support pre-FIT
> > configurations where the initrd and the kernel were stored in seperate
> > locations in flash. Now that all systems use FIT, we can simply say
> > "bootm 2008000".
> >
> > I suggest we don't need it, so we should change the environment to be
> >
> > #define CONFIG_BOOTCOMMAND "bootm 20080000”
>
> Sounds good to me.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20180213/ee510dd4/attachment.html>


More information about the openbmc mailing list