[PATCH linux dev-4.10 01/16] fsi: sbefifo: Rename sbefifo_release_client() for consistency

Eddie James eajames at linux.vnet.ibm.com
Fri Feb 16 02:47:00 AEDT 2018



On 02/15/2018 06:35 AM, Andrew Jeffery wrote:
> We have sbefifo_new_client(), which feels unmatched by the currently named
> sbefifo_client_release().

Acked-by: Eddie James <eajames at linux.vnet.ibm.com>

>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> ---
>   drivers/fsi/fsi-sbefifo.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
> index 0697a10d3eb3..4ac9e188e683 100644
> --- a/drivers/fsi/fsi-sbefifo.c
> +++ b/drivers/fsi/fsi-sbefifo.c
> @@ -314,7 +314,7 @@ static struct sbefifo_client *sbefifo_new_client(struct sbefifo *sbefifo)
>   	return client;
>   }
>
> -static void sbefifo_client_release(struct kref *kref)
> +static void sbefifo_release_client(struct kref *kref)
>   {
>   	struct sbefifo *sbefifo;
>   	struct sbefifo_client *client;
> @@ -353,7 +353,7 @@ static void sbefifo_get_client(struct sbefifo_client *client)
>
>   static void sbefifo_put_client(struct sbefifo_client *client)
>   {
> -	kref_put(&client->kref, sbefifo_client_release);
> +	kref_put(&client->kref, sbefifo_release_client);
>   }
>
>   static struct sbefifo_xfr *sbefifo_next_xfr(struct sbefifo *sbefifo)



More information about the openbmc mailing list