[PATCH u-boot v2016.07-aspeed-openbmc] aspeed: un-hardcode FIT configuration selection
Joel Stanley
joel at jms.id.au
Tue Feb 13 14:58:51 AEDT 2018
On Fri, Feb 2, 2018 at 1:37 PM, Brad Bishop <bradleyb at fuzziesquirrel.com> wrote:
> Rely on the FDT parser to select a FIT config when looking for a
> ramdisk_conf. This allows image builders to use arbitrary configuration
> names like /configurations/conf at foo.
Can you elaborate?
Do we even need this script? IIRC it was in place to support pre-FIT
configurations where the initrd and the kernel were stored in seperate
locations in flash. Now that all systems use FIT, we can simply say
"bootm 2008000".
I suggest we don't need it, so we should change the environment to be
#define CONFIG_BOOTCOMMAND "bootm 20080000"
Cheers,
Joel
>
> Signed-off-by: Brad Bishop <bradleyb at fuzziesquirrel.com>
> ---
> include/configs/ast-common.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/ast-common.h b/include/configs/ast-common.h
> index 89b0cd8533..fbae281811 100644
> --- a/include/configs/ast-common.h
> +++ b/include/configs/ast-common.h
> @@ -110,7 +110,7 @@
>
> #define CONFIG_BOOTCOMMAND \
> "fdt addr 20080000; " \
> - "if fdt get value ramdisk_conf /configurations/conf at 1 ramdisk; then " \
> + "if fdt get value ramdisk_conf /configurations/conf ramdisk; then " \
> " bootm 20080000; else bootm 20080000 20300000; " \
> "fi"
> #define CONFIG_ENV_OVERWRITE
> --
> 2.14.3
More information about the openbmc
mailing list