[PATCH linux dev-4.10 v3] ARM: dts: aspeed: Add ARM system BMC device tree
Joel Stanley
joel at jms.id.au
Wed Feb 7 18:19:12 AEDT 2018
On Wed, Feb 7, 2018 at 4:31 PM, Ken Chen <chen.kenyy at inventec.com> wrote:
> Add centriq2400-rep dts and modify platform initial
Hi Ken,
There are a number of issues with this patch that I commented on in my
last review of v2.
I suggest you reply to each of the comments in my previous review and
let me know if you've addressed them (a simple 'ok' is enough). If you
disagree with the review, please explain why you want to keep the code
as it is. If you need further clarification then that's fine too,
follow up questions are encouraged.
Finally, when you're preparing a new version, add a change log just
below the ---. You can see an example of that in this patch:
http://patchwork.ozlabs.org/patch/867147/
Cheers,
Joel
>
> Signed-off-by: Ken Chen <chen.kenyy at inventec.com>
> ---
> .../boot/dts/aspeed-bmc-arm-centriq2400-rep.dts | 286 +++++++++++++++++++++
> arch/arm/mach-aspeed/aspeed.c | 11 +
> 2 files changed, 297 insertions(+)
> create mode 100644 arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts
>
> diff --git a/arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts b/arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts
> new file mode 100644
> index 0000000..de1240b
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed-bmc-arm-centriq2400-rep.dts
> @@ -0,0 +1,286 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +/dts-v1/;
> +
> +#include "aspeed-g5.dtsi"
> +#include <dt-bindings/gpio/aspeed-gpio.h>
> +
> +/ {
> + model = "Qualcomm Centriq 2400 REP AST2520";
> + compatible = "qualcomm,centriq2400-rep-bmc", "aspeed,ast2500";
> +
> + chosen {
> + stdout-path = &uart5;
> + bootargs = "console=ttyS4,115200 earlyprintk";
> + };
> +
> + memory {
> + reg = <0x80000000 0x40000000>;
> + };
> +
> + iio-hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc 0>, <&adc 1>, <&adc 2>, <&adc 3>,
> + <&adc 4>, <&adc 5>, <&adc 6>, <&adc 8>;
> + };
> +
> + iio-hwmon-battery {
> + compatible = "iio-hwmon";
> + io-channels = <&adc 7>;
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + uid_led {
> + label = "UID_LED";
> + gpios = <&gpio ASPEED_GPIO(Q, 5) GPIO_ACTIVE_LOW>;
> + };
> +
> + ras_error_led {
> + label = "RAS_ERROR_LED";
> + gpios = <&gpio ASPEED_GPIO(F, 6) GPIO_ACTIVE_LOW>;
> + };
> +
> + system_fault {
> + label = "System_fault";
> + gpios = <&gpio ASPEED_GPIO(A, 1) GPIO_ACTIVE_LOW>;
> + };
> + };
> +};
> +
> +&fmc {
> + status = "okay";
> + flash at 0 {
> + status = "okay";
> + m25p,fast-read;
> + lable = "bmc";
> +#include "openbmc-flash-layout.dtsi"
> + };
> +};
> +
> +&spi1 {
> + status = "okay";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi1_default>;
> + flash at 0 {
> + reg = < 0 >; /* chip select number */
> + compatible = "jedec,spi-nor";
> + status = "okay";
> + };
> +};
> +
> +&spi2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_spi2ck_default &pinctrl_spi2miso_default &pinctrl_spi2mosi_default &pinctrl_spi2cs0_default>;
> +};
> +
> +&uart3 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_txd3_default
> + &pinctrl_rxd3_default>;
> + current-speed = <115200>;
> +};
> +
> +&lpc_ctrl {
> + status = "okay";
> + memory-region = <&flash_memory>;
> + flash = <&spi1>;
> +};
> +
> +&uart5 {
> + status = "okay";
> +};
> +
> +&mac0 {
> + status = "okay";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_rgmii1_default &pinctrl_mdio1_default>;
> +};
> +
> +&i2c0 {
> + status = "okay";
> +
> + pca9542 at 70 {
> + compatible = "pca9542";
> + reg = <0x70>;
> + i2c at 0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + pca9546 at 77 {
> + compatible = "pca9546";
> + reg = <0x77>;
> + i2c at 0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <0>;
> + eeprom at 52 {
> + compatible = "atmel,24c02";
> + reg = <0x52>;
> + };
> + };
> + i2c at 2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> + eeprom at 57 {
> + compatible = "atmel,24c02";
> + reg = <0x57>;
> + };
> + };
> + };
> + };
> + i2c at 1 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <1>;
> + pca9546 at 77 {
> + compatible = "pca9546";
> + reg = <0x77>;
> + i2c at 2 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> + reg = <2>;
> + eeprom at 57 {
> + compatible = "atmel,24c02";
> + reg = <0x57>;
> + };
> + };
> + };
> + };
> +
> + };
> +};
> +
> +&i2c1 {
> + status = "okay";
> +
> + tmp421 at 1e {
> + compatible = "ti,tmp421";
> + reg = <0x1e>;
> + };
> + tmp421 at 2a {
> + compatible = "ti,tmp421";
> + reg = <0x2a>;
> + };
> + tmp421 at 4e {
> + compatible = "ti,tmp421";
> + reg = <0x4e>;
> + };
> + tmp421 at 1c {
> + compatible = "ti,tmp421";
> + reg = <0x1c>;
> + };
> +};
> +
> +&i2c2 {
> + status = "okay";
> +};
> +
> +&i2c3 {
> + status = "okay";
> +};
> +
> +&i2c4 {
> + status = "okay";
> +};
> +
> +&i2c5 {
> + status = "okay";
> +};
> +
> +&i2c6 {
> + status = "okay";
> +
> + tmp421 at 1d {
> + compatible = "ti,tmp421";
> + reg = <0x1d>;
> + };
> + tmp421 at 1f {
> + compatible = "ti,tmp421";
> + reg = <0x1f>;
> + };
> + tmp421 at 4d {
> + compatible = "ti,tmp421";
> + reg = <0x4d>;
> + };
> + tmp421 at 4f {
> + compatible = "ti,tmp421";
> + reg = <0x4f>;
> + };
> + nvt210 at 4c {
> + compatible = "nvt210";
> + reg = <0x4c>;
> + };
> + eeprom at 50 {
> + compatible = "atmel,24c128";
> + reg = <0x50>;
> + pagesize = <128>;
> + };
> +};
> +
> +&i2c7 {
> + status = "okay";
> +};
> +
> +&i2c8 {
> + status = "okay";
> +
> + pca9641 at 70 {
> + compatible = "nxp,pca9641";
> + reg = <0x70>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + i2c-arb{
> + tmp421 at 1d {
> + compatible = "tmp421";
> + reg = <0x1d>;
> + };
> + adm1278 at 12 {
> + compatible = "adi,adm1278";
> + reg = <0x12>;
> + Rsense = <500>;
> + };
> + eeprom at 50 {
> + compatible = "atmel,24c02";
> + reg = <0x50>;
> + };
> + ds1100 at 58 {
> + compatible = "ds1100";
> + reg = <0x58>;
> + };
> + };
> + };
> +};
> +
> +&i2c9 {
> + status = "okay";
> +};
> +
> +&vuart {
> + status = "okay";
> +};
> +
> +&gfx {
> + status = "okay";
> +};
> +
> +&pinctrl {
> + aspeed,external-nodes = <&gfx &lhc>;
> +};
> +&wdt2 {
> + status = "okay";
> +};
> +
> +&gpio {
> + pin_gpio_c7 {
> + gpio-hog;
> + gpios = <ASPEED_GPIO(C, 7) GPIO_ACTIVE_HIGH>;
> + output;
> + line-name = "BIOS_SPI_MUX_S";
> + };
> +
> +}
> diff --git a/arch/arm/mach-aspeed/aspeed.c b/arch/arm/mach-aspeed/aspeed.c
> index 5965bbf..8fce9bc 100644
> --- a/arch/arm/mach-aspeed/aspeed.c
> +++ b/arch/arm/mach-aspeed/aspeed.c
> @@ -232,6 +232,15 @@ static void __init do_mellanox_setup(void)
> writel(reg, AST_IO(AST_BASE_SCU | 0x48));
> }
>
> +
> +static void __init do_centriq2400rep_setup(void)
> +{
> + u32 reg;
> +
> + do_common_setup();
> +}
> +
> +
> #define SCU_PASSWORD 0x1688A8A8
>
> static void __init aspeed_init_early(void)
> @@ -284,6 +293,8 @@ static void __init aspeed_init_early(void)
> do_lanyang_setup();
> if (of_machine_is_compatible("mellanox,msn-bmc"))
> do_mellanox_setup();
> + if (of_machine_is_compatible("qualcomm,centriq2400-rep-bmc"))
> + do_centriq2400rep_setup();
> }
>
> static void __init aspeed_map_io(void)
> --
> 2.9.3
>
More information about the openbmc
mailing list