Linux dev-4.19

Thu Dec 13 18:30:22 AEDT 2018

Hi Joel,

Regarding the EMC driver I made a lot of changes according to your comment and Benjamin comments:
  - Use "dev_*" for massages
  - Remove all code not defined to CONFIG_OF
  - Use debug_fs instead of proc_*
  - VLAN is handled more gently
  - Change order of functions
  - Remove CONFIG_NPCM7XX_EMC_ETH_DEBUG_EXT
  - Change _raw_readl and _raw_writel to readl and writel
  - Remove muxing (done in pinmux driver)
  - Change HW related variables from "unsigned int' to '__le32'
  - Remove irrelevant error cases
  - Remove redundant locks
  - Remove redundant of_match_device()
  - Remove ether_setup(), it is done inside alloc_etherdev()
  - Remove naming the device (let the network stuck pick a name)
  - Some definition and function renaming
  - syntax and code style changes
  - update dts binding document

But still some comments from Benjamin that requires more risky modification were not done yet.
The driver we have works around some HW issues that some of them are hard to reproduce, so I am afraid (at this point) that some design changes might break them.
This driver was heavily tested on our site and our main OEM customer.

Note that on our next BMC chip we will not use this IP so this IP only applies to our Poleg.

Thanks,
Avi

-----Original Message-----
From: openbmc <openbmc-bounces+avifishman70=gmail.com at lists.ozlabs.org> On Behalf Of Joel Stanley
Sent: Thursday, December 13, 2018 2:56 AM
To: Tomer Maimon <tmaimon77 at gmail.com>
Cc: OpenBMC Maillist <openbmc at lists.ozlabs.org>
Subject: Re: Linux dev-4.19

> > Commit upstream to kernel 4.20
> > hwmon: (npcm-750-pwm-fan) Change initial pwm target to 255
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_torvalds_linux.git_commit_-3Fid-3Df21c8e753
> > b1dcb8f9e5b096db1f7f4e6fdfa7258&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC
> > 01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahPM6I78&m=E
> > LnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=p-LAPdYOBNI_KKIH_DawlHJ
> > J3Tg8yjs5fSCwchxODZM&e=

Done.

> > Commits will upstream to kernel 4.21
> >
> > dt-binding: spi: add NPCM PSPI controller documentation
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D4ad26864df53b265976c4a3ae61b1e6cad92fe40&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=eQUcYfJdc
> > q4ItYmLDngSe9Qi9AQy2F86uhAeHQb4hnc&e=
> >
> > spi: npcm: add NPCM PSPI controller driver
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D2a22f1b30cee8d1e104a6c5062a609bedbfd5c39&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=L0d6tgcA8
> > EoveyNtN_Bdvbwc8gJawe8Bt3EE7n7pqkQ&e=
> >
> > spi: npcm: fix u32 csgpio being checked for less than zero
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D757ec116c9bce4278fa4423039736c832cc63b6f&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=qsjXlXRQx
> > Vl5uv4uX8AWCP2QPkydR_xHDgBzSOZtJ3E&e=
> >
> > spi: npcm: fix platform_no_drv_owner.cocci warnings
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D7986e2273c1ed987ff34f1c318d5a2b18e8c0fee&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=RIeQRFrcu
> > KbmisiBMBQQhvWIyEPyQT5zfS2TstwafJw&e=
> >
> > spi: npcm: Fix an error code in the probe function
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D428f977a6a6b43154928571b01fa8415c11a9244&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=jreMCKH6o
> > AAnq29T0VeO82kFFRzpRpyV0T0X9VoAoRs&e=
> >
> > spi: npcm: Fix uninitialized variable warning
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D1d2319efb6a970d5f5740a60828244e6c309df2b&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=bFEkqbBjn
> > RqbjjNzw71SDKhuEj9O4LL2FoVOxLjhfDM&e=
> >
> > spi: npcm: Modify pspi send function
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D1fa33be36cfc8908be951ed56113906f422add50&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=7ma2h-PUg
> > cEVoXYOT4NdiS1lmlCl04KzZFNoms2OwFw&e=
> >
> > spi: Update NPCM PSPI controller documentation
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_
> > pub_scm_linux_kernel_git_broonie_spi.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D6ab4a3502923c20c5a6921868e787e5fd033409b&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=jVF-Ct8jm
> > w17vCdIW1uTiqqO9gcz4Ox26-FL_rGnTm4&e=
> >
> > pinctrl: nuvoton: modify NPCM7xx pin configuration function
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.linaro.org_
> > people_linus.walleij_linux-2Dpinctrl.git_commit_-3Fh-3Dfor-2Dnext-26
> > id-3D67b249aaa650a461c86484e6c365f33887f0968a&d=DwIBaQ&c=ue8mO8zgC4V
> > Z4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneH
> > prahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=49tWS3XDC
> > am5Uu_hiD4YhuhKGVu7ck8e5F09JAWlpZM&e=
> >
> > watchdog: npcm: Modify npcm watchdog kconfig arch parameter
> >
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__kernel.googleso
> > urce.com_pub_scm_linux_kernel_git_groeck_linux-2Dstaging_-2B_4181f4a
> > 55838db15deaed315b11bfab395be0a17&d=DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9
> > MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahPM6I78&m
> > =ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=tvoCWtzFhztDogtqxhkcm
> > AIdwA00ysyb_AjV4L1wftk&e=

All of the above are now done. I built your defconfig and net booted it on the poleg evb I have:

 Booting Linux on physical CPU 0x0
 Linux version 4.19.8-00077-gdfde697b6cae (joel at aurora) (gcc version
8.2.0 (Ubuntu 8.2.0-7ubuntu1)) #2 SMP Thu Dec 13 11:24:12 ACDT 2018
 CPU: ARMv7 Processor [414fc091] revision 1 (ARMv7), cr=18c5387d
 CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache
 OF: fdt: Machine model: Nuvoton npcm750 Development Board (Device Tree)

> > Commits on upstream process
> >
> > dt-binding: mtd: add NPCM FIU controller
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_f13c82dca3ca21175eb71223156d5c525c18dd74&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=2H7RgZDWGaC51J4vgPlPI-sMoN9WgdnCDzQPUFRON4g&e=
> >
> > mtd: spi-nor: add NPCM FIU controller driver
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_747809a0082dbeaaa6b786842c5c5eaffa519561&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=w6AEFBwRPA2BJjYM36bylDBN7fUBSBoi2MHkjdeF6TA&e=
> >
> > dt-bindings: i2c: npcm7xx: add binding for i2c controller
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_07be53b47443fcab645f0e67c03e3912387ff9a7&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=Bv8gjLQnWmv4U7_X2jkDTzLWms-uhPOsKwDj3sA0JJU&e=
> >
> > i2c: npcm: driver for Poleg i2c controller
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_3a7f3375024461d3db17a78cb7d83dafcc2dbc6c&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=0n2DQYGCcLyKKX0KXXfNa9r3abwa2WrkwMssKoat6Uk&e=
> >
> > dt-binding: bmc: Add NPCM7xx LPC BPC documentation
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_e8b6cc1c31e744b3fd5630d790af65ac38b2c24d-2
> > 3diff-2De7386aa740d12baf8cdc2a0ab8e5347c&d=DwIBaQ&c=ue8mO8zgC4VZ4q_a
> > NVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahP
> > M6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=oZrISIjyD73eDp
> > wNC3w1IGykiKiThz9E1GciypWG4JE&e=
> >
> > misc: npcm7xx-lpc-bpc: add NPCM7xx BIOS post code driver
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_adee227ac24431cd033f1c44b63d5a244a0bdd3b-2
> > 3diff-2D7081e24727d8058bcc6ebf20230f5403&d=DwIBaQ&c=ue8mO8zgC4VZ4q_a
> > NVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahP
> > M6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=alY6eLY617LOoH
> > uCc4v-5rAuV4cfEBp5to068p8YHbY&e=
> >
> > misc: bpc: modify remove function in npcm7xx bpc driver
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_1c5268f9b17f9333ee2fb245f84729beebb66a9c-2
> > 3diff-2D7081e24727d8058bcc6ebf20230f5403&d=DwIBaQ&c=ue8mO8zgC4VZ4q_a
> > NVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cOhaTMIUoFhUPAXV51uTneHprahP
> > M6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dUXPt9LhzMI&s=_cLlHO1RCi38nA
> > 3CbTcEvS6xQl1Vgxo1NIg8NFa4YeI&e=
> >
> > PCI mail box commits
> >
> > dt-binding: bmc: add npcm7xx pci mailbox document
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_7da4f41849aef11b1a9a6e05773545f181246496&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=pxvcmyURp3NUcE5B85JTbC2Qs4K8JkF9M-FQ9nDQS5w&e=
> >
> > misc: mbox: add npcm7xx pci mailbox driver
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_c3d5d2bab5ad216e6c0debabf50ad8365f2301d1&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=llrGcnZgWtFx-9P1WtuHN6b5SJJwIne7o6PVydacNbg&e=
> >
> > EMC net commits
> >
> > net: npcm: add NPCM7xx Ethernet MAC controller
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_6a9407ed142ff2c205d732d4d3477a8e9f7d950b&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=83uHEIideztXcSfkW2SCWBbYRT8Tx93qw_zUa2B8hbA&e=
> >
> > dt-binding: net: document NPCM7xx EMC DT bindings
> > https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_Nuvo
> > ton-2DIsrael_linux_commit_66478b88409dba415a7bb008ce833afa3957fb2d&d
> > =DwIBaQ&c=ue8mO8zgC4VZ4q_aNVKt8G9MC01UFDmisvMR1k-EoDM&r=kNeU5gwNy2cO
> > haTMIUoFhUPAXV51uTneHprahPM6I78&m=ELnAIsbPD6kfaIjJddqVj93bljYNEcj2dU
> > XPt9LhzMI&s=zs2C0EYbR9AtwyKnqbBqXa-So3XdScMoMsNrdmwaW88&e=

Not all of the above commits do not have signed-off-bys. This is required for putting it in the kernel tree.

Instead of cherry-picking these from your tree, I would prefer to see them posted to the mailing list where I can apply them. Can you please send them out using git send-email, and we can go from there?

I have applied the device tree patch you sent.

Can you please re-send the defconfig using git-send-email and name it 'poleg_defconfig' or 'poleg_svb_defconfig' (what is SVB?) to match the defconfig naming convention. It should be generated against the
dev-4.19 tree (make poleg_defconfig && make savedefconfig && cp defconfig arch/arm/config/poleg_defconfig).

Cheers,

Joel

===========================================================================================
The privileged confidential information contained in this email is intended for use only by the addressees as indicated by the original sender of this email. If you are not the addressee indicated in this email or are not responsible for delivery of the email to such a person, please kindly reply to the sender indicating this fact and delete all copies of it from your computer and network server immediately. Your cooperation is highly appreciated. It is advised that any unauthorized use of confidential information of Nuvoton is strictly prohibited; and any information in this email irrelevant to the official business of Nuvoton shall be deemed as neither given nor endorsed by Nuvoton.