[HELP] ipmi-kcs didn't work

[Jae Hyun Yoo]

On 12/4/2018 12:18 AM, Ryan Chen wrote:
> Hello Jae,
> 	ASPEED LPC IP HW block have serval clk input.
> 	Most important is LCLK is come from LPC Host.
> 	The others is not controllable by register.
> Ryan
> 

Hi Ryan,

Thanks for the information. So clock source of LCLK is from external
usually from PCH, means that it doesn't have any parent dependency
within BMC. In this case, we need to mark CLK_IS_CRITICAL flag to enable
it. Also, we should mark the flag for ESPICLK too because eSPI is
sharing the same interface with LPC.

I'll make and upstream a patch.

Thanks,
Jae

> -----Original Message-----
> From: Vijay Khemka [mailto:vijaykhemka at fb.com]
> Sent: Tuesday, December 4, 2018 3:38 AM
> To: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>; Samuel Jiang <chyishian.jiang at gmail.com>; qianlihu <wangzhiqiang8906 at gmail.com>; Gary Hsu <gary_hsu at aspeedtech.com>; Ryan Chen <ryan_chen at aspeedtech.com>
> Cc: openbmc at lists.ozlabs.org
> Subject: Re: [HELP] ipmi-kcs didn't work
> 
> 
> 
> On 12/3/18, 7:54 AM, "Jae Hyun Yoo" <jae.hyun.yoo at linux.intel.com> wrote:
> 
>      On 12/1/2018 8:29 AM, Samuel Jiang wrote:
>      > Apologize for sending out no content mail first.
>      >
>      > Jae,
>      > The aspeed_gates in clk-aspeed.c perhaps as todo suggest asking Aspeed
>      > the actual parent data for check initializing?
>      >
>      
>      Yes, that makes sense.
>      
>      Hi Gary and Ryan,
>      
>      Can you please tell us what is the actual parent clock source of LPC IP?
>      I mean the operational clock of LPC IP hardware block, not the interface
>      clock.
>      
>      Thanks,
>      Jae
>      
>      > Vijay,
>      > I traced lpc-ctrl module, it seems direct update the same
>      > ASPEED_CLK_GATE_LCLK register map bit to enable. If parent data is
>      > disabled, it could enable in dts.
>      > The device tree detail, I reference it from aspeed-g5.dtsi. Hope it
>      > could help you for work.
>      >
>      > Thanks,
>      >
>      > Samuel Jiang
> 
> Samual/Jay,
> In my case if I don't initialize LPC clock in driver, Bios on host side wait and doesn't boot.
> I don't understand here what is holding Bios here but by initializing this LPC clock let bios boot.
> 
> Regards
> -Vijay
>