[PATCH] clk: npcm7xx: fix memory allocation

Stephen Boyd sboyd at kernel.org
Wed Aug 29 08:13:27 AEST 2018


Quoting Gustavo A. R. Silva (2018-08-23 16:06:54)
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
> 
> struct foo {
>         int stuff;
>         void *entry[];
> };
> 
> instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count,
> GFP_KERNEL);
> 
> Instead of leaving these open-coded and prone to type mistakes, we can
> now use the new struct_size() helper:
> 
> instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);
> 
> Notice that, currently, there is a bug during the allocation:
>         
> sizeof(npcm7xx_clk_data) should be sizeof(*npcm7xx_clk_data)
> 
> Fix this bug by using struct_size() in kzalloc()
> 
> This issue was detected with the help of Coccinelle.
> 
> Cc: stable at vger.kernel.org
> Signed-off-by: Gustavo A. R. Silva <gustavo at embeddedor.com>
> ---

Applied to clk-fixes



More information about the openbmc mailing list