[PATCH linux dev-4.13] clk:aspeed: Fix reset assert logic

Jae Hyun Yoo jae.hyun.yoo at linux.intel.com
Fri Apr 27 03:00:03 AEST 2018


On 4/25/2018 6:56 PM, Joel Stanley wrote:
> On 26 April 2018 at 08:03, Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com> wrote:
>> This commit fixes a bug in aspeed_reset_assert() which determines
>> the second reset register using condition.
>>
>> Signed-off-by: Jae Hyun Yoo <jae.hyun.yoo at linux.intel.com>
> 
> Thanks. This patch has not been applied upstream, so I will send a V2
> that incorporates your fix.
> 
> I've applied this patch to dev-4.13.
> 
> Cheers,
> 
> Joel
> 

Thanks a lot for your review.

Jae

>> ---
>>   drivers/clk/clk-aspeed.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/clk/clk-aspeed.c b/drivers/clk/clk-aspeed.c
>> index de8e1dba6eec..c5d2af2ace2e 100644
>> --- a/drivers/clk/clk-aspeed.c
>> +++ b/drivers/clk/clk-aspeed.c
>> @@ -349,7 +349,7 @@ static int aspeed_reset_assert(struct reset_controller_dev *rcdev,
>>          u32 reg = ASPEED_RESET_CTRL;
>>          u32 bit = aspeed_resets[id];
>>
>> -       if (bit >= ASPEED_RESET_CTRL2) {
>> +       if (bit >= ASPEED_RESET2_OFFSET) {
>>                  bit -= ASPEED_RESET2_OFFSET;
>>                  reg = ASPEED_RESET_CTRL2;
>>          }
>> --
>> 2.17.0
>>


More information about the openbmc mailing list