FW: [PATCH linux dev-4.13 v1] ARM: dts: aspeed: Add Inventec Lanyang BMC

Andrew Jeffery andrew at aj.id.au
Thu Apr 19 11:36:05 AEST 2018

On Thu, 19 Apr 2018, at 10:27, Joel Stanley wrote:
> On 17 April 2018 at 11:35, Andrew Jeffery <andrew at aj.id.au> wrote:
> >> >> +&i2c11 {
> >> >> +     status = "okay";
> >> >> +};
> >> >
> >> > Do we need to enable all of the above i2c buses? By comparison, Zaius enables i2c0, i2c1, i2c4, i2c7 and i2c8.
> >>
> >> Thank you for your review.
> >>
> >> We need to enable all of the above i2c buses because we want to verify
> >> the i2c bus is fine by i2ctool.
> >>
> >> Because we use the above i2c buses on Lanyang platform.
> >
> > Okay, it's still not clear to me. Are there devices on all the buses? If so, do any have bindings that we could use to describe them here? It looks odd enabling all the buses but not "using" any of them.
> >
> > If you're just enabling them to test the bus with i2ctool then I feel that we might be better with that staying as a local change for your testing, rather than merging this as is. Joel?
> If they exist on in the design, then enabling them is fine.
> The distinction I've gone with is it doesn't make sense to have them
> enabled when the i2c pads on the SoC are not broken out, or if they're
> only connected to ground, so there's no way of them ever "working".
> I'm happy with the dt as is it is. If you're happy then I will merge.

Yeah I don't feel strongly about it, just it looked odd.

Acked-by: Andrew Jeffery <andrew at aj.id.au>

More information about the openbmc mailing list