[PATCH linux dev-4.13 4/5] pmbus (core): Use driver callbacks in pmbus_get_fan_rate()

[Eddie James]

On 04/03/2018 09:26 AM, Andrew Jeffery wrote:
> The driver may have overridden the pmbus_read_byte_data() callback, so
> make sure we use that to achieve expected behaviour.
>
> This helps in the MAX31785 case where we may need to perform a one-shot
> retry of transfers in the face of a failure.

Reviewed-by: Eddie James <eajames at linux.vnet.ibm.com>

>
> Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> ---
>   drivers/hwmon/pmbus/pmbus_core.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> index ee1bf11c7fc6..d0ffa4b3fcbd 100644
> --- a/drivers/hwmon/pmbus/pmbus_core.c
> +++ b/drivers/hwmon/pmbus/pmbus_core.c
> @@ -453,15 +453,15 @@ static int pmbus_get_fan_rate(struct i2c_client *client, int page, int id,
>   		return s->data;
>   	}
>
> -	config = pmbus_read_byte_data(client, page,
> -				      pmbus_fan_config_registers[id]);
> +	config = _pmbus_read_byte_data(client, page,
> +				       pmbus_fan_config_registers[id]);
>   	if (config < 0)
>   		return config;
>
>   	have_rpm = !!(config & pmbus_fan_rpm_mask[id]);
>   	if (want_rpm == have_rpm)
> -		return pmbus_read_word_data(client, page,
> -					    pmbus_fan_command_registers[id]);
> +		return _pmbus_read_word_data(client, page,
> +					     pmbus_fan_command_registers[id]);
>
>   	/* Can't sensibly map between RPM and PWM, just return zero */
>   	return 0;