[PATCH linux dev-4.10] ARM: dts: aspeed-g4: Fix timeriomem_rng probing

Joel Stanley joel at jms.id.au
Fri Sep 22 13:20:03 AEST 2017


On Fri, Sep 22, 2017 at 12:29 AM, Rick Altherr <raltherr at google.com> wrote:
> Is this superseded by the later patch that change syscon to include a
> ranges property?

Yep, spot on.

I didn't make the follow up v2, given it had little resemblance.
Perhaps I will next time to see if it results in less confusion :)

Cheers,

Joel

>
> On Wed, Sep 20, 2017 at 11:23 PM, Joel Stanley <joel at jms.id.au> wrote:
>> When booting we see this error:
>>
>>  timeriomem_rng 1e6e2000.syscon:hwrng at 1e6e2078: timeriomem_rng: resource is missing
>>
>> Moving the timeriomem_rng node outside of the syscon fixes the issue.
>>
>> Signed-off-by: Joel Stanley <joel at jms.id.au>
>> ---
>>  arch/arm/boot/dts/aspeed-g4.dtsi | 14 +++++++-------
>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/aspeed-g4.dtsi b/arch/arm/boot/dts/aspeed-g4.dtsi
>> index a83b6a8d73d4..38aadbf09be2 100644
>> --- a/arch/arm/boot/dts/aspeed-g4.dtsi
>> +++ b/arch/arm/boot/dts/aspeed-g4.dtsi
>> @@ -195,18 +195,18 @@
>>                                         reg = <0x2c>;
>>                                 };
>>
>> -                               hwrng at 1e6e2078 {
>> -                                       compatible = "timeriomem_rng";
>> -                                       reg = <0x1e6e2078 0x4>;
>> -                                       period = <1>;
>> -                                       quality = <100>;
>> -                               };
>> -
>>                                 pinctrl: pinctrl at 1e6e2000 {
>>                                         compatible = "aspeed,g4-pinctrl";
>>                                 };
>>                         };
>>
>> +                       hwrng at 1e6e2078 {
>> +                               compatible = "timeriomem_rng";
>> +                               reg = <0x1e6e2078 0x4>;
>> +                               period = <1>;
>> +                               quality = <100>;
>> +                       };
>> +
>>                         adc: adc at 1e6e9000 {
>>                                 compatible = "aspeed,ast2400-adc";
>>                                 reg = <0x1e6e9000 0xB0>;
>> --
>> 2.14.1
>>


More information about the openbmc mailing list