[PATCH linux dev-4.10 v6 0/3] Add user space accessibility for ucd9000 stats

[Andrew Jeffery]

On Wed, 2017-08-30 at 16:49 -0500, Christopher Bostic wrote:
> This set provides means to allow user space to access various properties of the
> ucd9000 type chips.
> 
> Patch 0001 Adds a user space means of clearing logged faults.  This ability is
> useful in cases where one wants to start with a clean slate during each system
> power on.
> 
> patch 0002 Adds gpio_chip interface for user to access various GPIO pin states
> via the /sys/class/gpio interface.
> 
> Patch 0003 adds a debugfs for mfr_status information so user space can gain
> visibility of gpi type faults. Note that there are limitations on type of devices
> that debugfs supports.  Presently only ucd90160 is supported.  Any assumptions made
> as to formatting of data is commented inline in the code.  Any expansion to other
> ucd9000 types will need to take this into consideration.
> 
> Note also that no pinmux support is provided at this point.  The ucd9000 devs do
> have mux capability so this should be added.
> 
> Patch 0003 (was patch v5-0002... previously) has been reviewed by Andrew Jeffery,
> I did, however, add some small updates to this one:
> 
> * Remove ida in bad and unbind paths.
> * Remove type ucd90160 check when adding debugfs. Add for all ucd9000 devs.
>   Results in cleaner ida code in the remove path.

Thanks for the summary and for splitting out the patch introducing the
new ABI.

Unfortunately upstream NACKed what you've put as the first patch in
your series. In the future, it's best to order controversial patches
later, that way we can apply the uncontroversial patches without fuzz
or failures from context/content dependencies.

So given I can't apply the first patch as we know it won't go upstream,
I can't apply the rest either due to hunks failing or fuzzing. Can you
please respin, and given you need to do that, take into account
Guenter's feedback?

Cheers,

Andrew

> 
> Christopher Bostic (3):
>   hwmon: (ucd9000) Add interface to clear logged faults.
>   hwmon: (ucd9000) Add gpio chip interface
>   hwmon: (ucd9000) Add debugfs to list mfr_status info
> 
>  drivers/hwmon/pmbus/ucd9000.c | 415 +++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 413 insertions(+), 2 deletions(-)
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20170901/35377640/attachment.sig>