[PATCH linux dev-4.10] pmbus: core: Switch PAGE failure dev_warn() to dev_dbg() for serenity

Andrew Jeffery andrew at aj.id.au
Mon Oct 30 14:37:09 AEDT 2017


On Sun, 2017-10-29 at 22:00 -0500, Andrew Geissler wrote:
> > On Sun, Oct 29, 2017 at 7:27 PM, Andrew Jeffery <andrew at aj.id.au> wrote:
> > Reduce kernel log spam from PMBus core failing a PAGE command to the
> > MAX37185 (and any other device). It's a hardware-design or driver
> > related fault, and is not anything the user can fix. Therefore reduce
> > it from warn to debug.
> > 
> > Signed-off-by: Andrew Jeffery <andrew at aj.id.au>
> > ---
> >  drivers/hwmon/pmbus/pmbus_core.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_core.c
> > index d4e959bda491..c4b551b9226c 100644
> > --- a/drivers/hwmon/pmbus/pmbus_core.c
> > +++ b/drivers/hwmon/pmbus/pmbus_core.c
> > @@ -175,9 +175,9 @@ int pmbus_set_page(struct i2c_client *client, u8 page)
> >                 if (rv) {
> >                         rv = i2c_smbus_write_byte_data(client, PMBUS_PAGE,
> >                                                        page);
> > -                       dev_warn(&client->dev,
> > -                                "Failed to set page %u, performed one-shot retry %s: %d\n",
> > -                                page, rv ? "and failed" : "with success", rv);
> > +                       dev_dbg(&client->dev,
> > +                               "Failed to set page %u, performed one-shot retry %s: %d\n",
> > +                               page, rv ? "and failed" : "with success", rv);
> >                 }
> > 
> >                 newpage = i2c_smbus_read_byte_data(client, PMBUS_PAGE);
> > --
> > 2.11.0
> > 
> 
> Acked-by: Andrew Geissler <geissonator at gmail.com>

Thanks, applied to dev-4.10 with your ack.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20171030/19a70a36/attachment.sig>


More information about the openbmc mailing list