[PATCH linux dev-4.10] ARM: dts: aspeed: Use new occ-hwmon driver for P8 systems

Andrew Jeffery andrew at aj.id.au
Mon Oct 30 14:19:09 AEDT 2017


On Fri, 2017-10-27 at 13:26 +0800, Lei YU wrote:
> Use the new occ-hwmon driver and compatible name for
> Barreleye and Garrison.
> 
> Signed-off-by: Lei YU <mine260309 at gmail.com>
> ---
>  arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts |  8 ++++----
>  arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts  | 10 +++++-----
>  2 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> index d37d0ea..6e70ca5 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts
> @@ -124,13 +124,13 @@
>  &i2c3 {
>  	status = "okay";
>  
> -	occ at 50 {
> -		compatible = "ibm,occ-i2c";
> +	occ-hwmon at 50 {

I tend to disagree with the node name. 'occ-hwmon' reflects the hardware *and*
a Linux subsystem, which is not what a node name should represent. My
alternative would be 'occ-sensors', and maybe we can bikeshed that. However,
the patch is consistent with what we have in other devicetrees. We should fix
what we have, but I think that's a job for another day.

> +		compatible = "ibm,p8-occ-hwmon";
>  		reg = <0x50>;
>  	};
>  
> -	occ at 51 {
> -		compatible = "ibm,occ-i2c";
> +	occ-hwmon at 51 {
> +		compatible = "ibm,p8-occ-hwmon";
>  		reg = <0x51>;
>  	};
>  };
> diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts b/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts
> index 6b96e36..95552c8 100644
> --- a/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts
> +++ b/arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts
> @@ -156,8 +156,8 @@
>  &i2c4 {
>  	status = "okay";
>  
> -	occ at 50 {
> -		compatible = "ibm,occ-i2c";
> +	occ-hwmon at 50 {
> +		compatible = "ibm,p8-occ-hwmon";
>  		reg = <0x50>;
>  	};
>  };
> @@ -165,9 +165,9 @@
>  &i2c5 {
>  	status = "okay";
>  
> -	occ at 50 {
> -		compatible = "ibm,occ-i2c";
> -		reg = <0x50>;
> +	occ-hwmon at 51 {
> +		compatible = "ibm,p8-occ-hwmon";
> +		reg = <0x51>;
>  	};
>  };
>  
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20171030/b01daf55/attachment.sig>


More information about the openbmc mailing list