[PATCH linux dev-4.10] drivers (pmbus): ir35221: Set PMBUS_PAGE before reading id and model

[Andrew Jeffery]

On Thu, 2017-10-19 at 15:48 -0500, Eddie James wrote:
> From: "Edward A. James" <eajames at us.ibm.com>
> 
> The MFR_ID and MFR_MODEL, which are manually read before probing the
> pmbus core,  are only valid for the two pages that the ir35221 has
> available. Since we don't know the state of the device when we start
> probing, set the page number first before reading id and model.
> 
> Signed-off-by: Edward A. James <eajames at us.ibm.com>

Thanks, applied to dev-4.10.

Andrew

> ---
>  drivers/hwmon/pmbus/ir35221.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/hwmon/pmbus/ir35221.c b/drivers/hwmon/pmbus/ir35221.c
> index cc7b3b5..9aae633 100644
> --- a/drivers/hwmon/pmbus/ir35221.c
> +++ b/drivers/hwmon/pmbus/ir35221.c
> @@ -243,6 +243,12 @@ static int ir35221_probe(struct i2c_client *client,
>  				| I2C_FUNC_SMBUS_READ_BLOCK_DATA))
>  		return -ENODEV;
>  
> +	ret = i2c_smbus_write_byte_data(client, PMBUS_PAGE, 0);
> +	if (ret < 0) {
> +		dev_err(&client->dev, "Failed to set PMBUS_PAGE\n");
> +		return ret;
> +	}
> +
>  	ret = i2c_smbus_read_block_data(client, PMBUS_MFR_ID, buf);
>  	if (ret < 0) {
>  		dev_err(&client->dev, "Failed to read PMBUS_MFR_ID\n");
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20171020/92060177/attachment-0001.sig>