[PATCH linux dev-4.10 v4 03/31] drivers: fsi: sbefifo: Use __be32 for big endian values
Eddie James
eajames at linux.vnet.ibm.com
Fri Oct 6 13:05:25 AEDT 2017
From: "Edward A. James" <eajames at us.ibm.com>
Use a real __be32 value instead of u32 for big endian values.
Signed-off-by: Edward A. James <eajames at us.ibm.com>
Reviewed-by: Andrew Jeffery <andrew at aj.id.au>
---
drivers/fsi/fsi-sbefifo.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c
index 2e45a75..c5eeace 100644
--- a/drivers/fsi/fsi-sbefifo.c
+++ b/drivers/fsi/fsi-sbefifo.c
@@ -103,7 +103,7 @@ struct sbefifo_client {
static int sbefifo_inw(struct sbefifo *sbefifo, int reg, u32 *word)
{
int rc;
- u32 raw_word;
+ __be32 raw_word;
rc = fsi_device_read(sbefifo->fsi_dev, reg, &raw_word,
sizeof(raw_word));
@@ -111,17 +111,19 @@ static int sbefifo_inw(struct sbefifo *sbefifo, int reg, u32 *word)
return rc;
*word = be32_to_cpu(raw_word);
+
return 0;
}
static int sbefifo_outw(struct sbefifo *sbefifo, int reg, u32 word)
{
- u32 raw_word = cpu_to_be32(word);
+ __be32 raw_word = cpu_to_be32(word);
return fsi_device_write(sbefifo->fsi_dev, reg, &raw_word,
sizeof(raw_word));
}
+/* Don't flip endianness of data to/from FIFO, just pass through. */
static int sbefifo_readw(struct sbefifo *sbefifo, u32 *word)
{
return fsi_device_read(sbefifo->fsi_dev, SBEFIFO_DWN, word,
--
1.8.3.1
More information about the openbmc
mailing list