[PATCH linux dev-4.10 v3 24/31] drivers: fsi: occ: Remove unnecessary platform_set_drvdata call

[Andrew Jeffery]

On Thu, 2017-10-05 at 19:33 -0500, Eddie James wrote:
> 
> On 10/05/2017 06:14 PM, Andrew Jeffery wrote:
> > On Thu, 2017-10-05 at 14:24 -0500, Eddie James wrote:
> > > > > > From: "Edward A. James" <eajames at us.ibm.com>
> > >   
> > > The purpose was to set that pointer null before probing. However, it is
> > > set null by the kernel by default.
> > >   
> > > > > > Signed-off-by: Edward A. James <eajames at us.ibm.com>
> > > ---
> > >   drivers/fsi/occ.c | 3 ---
> > >   1 file changed, 3 deletions(-)
> > >   
> > > diff --git a/drivers/fsi/occ.c b/drivers/fsi/occ.c
> > > index 916c342..561b029 100644
> > > --- a/drivers/fsi/occ.c
> > > +++ b/drivers/fsi/occ.c
> > > @@ -703,9 +703,6 @@ static int occ_probe(struct platform_device *pdev)
> > > > > >   	mutex_init(&occ->occ_lock);
> > > > > >   	INIT_WORK(&occ->work, occ_worker);
> > >   
> > > > > > -	/* ensure NULL before we probe children, so they don't hang FSI */
> > > > > > -	platform_set_drvdata(pdev, NULL);
> > > -
> > 
> > Bizarre that it was even there in the first place - do you know the history of
> > the comment?
> 
> I made the comment. I wasn't sure if there were situations where that 
> wouldn't be NULL before probe() somehow. Regarding the hanging FSI... 
> that was before some FSI core fixes were in that prevent that situation 
> during probe().

Fair enough.

Reviewed-by: Andrew Jeffery <andrew at aj.id.au>

> 
> > 
> > > > > >   	if (dev->of_node) {
> > > > > >   		rc = of_property_read_u32(dev->of_node, "reg", &reg);
> > >   		if (!rc) {
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20171006/c994eeac/attachment.sig>