[PATCH] fsi/master: Clarify master lifetimes & fix use-after-free in hub master

Joel Stanley joel at jms.id.au
Wed Oct 4 15:29:10 AEDT 2017


On Tue, Oct 3, 2017 at 10:41 AM, Christopher Bostic
<cbostic at linux.vnet.ibm.com> wrote:
> On 10/2/17 7:32 PM, Jeremy Kerr wrote:
>>
>> Once we call fsi_master_unregister, the core will put_device,
>> potentially freeing the hub master. This change adds a comment
>> explaining the lifetime of an allocated fsi_master.
>>
>> We then add a reference from the driver to the hub master, so it stays
>> around until we've finished ->remove().
>>
>> Signed-off-by: Jeremy Kerr <jk at ozlabs.org>
> Tested-by: Christopher Bostic <cbostic at linux.vnet.ibm.com>

Applied to dev-4.10.

We should also create a tree with these fixes for upstream inclusion.

Cheers,

Joel


More information about the openbmc mailing list