[PATCH linux dev-4.10 v2 2/2] ARM: dts: Add Wfp BMC Machine

[James Feist]

On 11/29/2017 01:20 AM, Joel Stanley wrote:
> On Wed, Nov 29, 2017 at 5:58 AM, James Feist
> <james.feist at linux.intel.com> wrote:
>> Wfp is a Intel system with an Aspeed ast2500 BMC.
> 
> Is WFP an acronym? It would be good to spell it out in the commit message.
> 
It is not an acronym, it is a short name to describe current generation 
Intel boards.

> Andrew, can you please review the bits of the device tree that you're
> familiar with (mostly pinmux)?
> 
> 
>> +
>> +       chosen {
>> +               stdout-path = &uart5;
>> +               bootargs = "115200 earlyprintk";
> 
> I don't think 115200 will do anything. Can you explain your intent here?

Will delete.

> 
>> +       };
>> +
>> +       memory {
>> +               reg = <0x80000000 0x20000000>;
>> +       };
> 
> There's no reserved region for the VGA framebuffer, but you enable the
> GFX node below.
> 
> With the openbmc u-boot tree the size of the memory is adjusted to
> account for the framebuffer at the top of memory, but I was lead to
> believe Intel machines use their own u-boot fork.
> 
We don't use u-boot, but I will fix this.

> Cheers,
> 
> Joel
> 

Thanks,

James