Gerrit code review velocity

Andrew Jeffery andrew at aj.id.au
Thu Nov 16 13:09:14 AEDT 2017


On Wed, 2017-11-15 at 19:09 -0500, Brad Bishop wrote:
> > Do we have  a process for how long code review->test->merge should
> > take, and what process it should follow?
> 
> We don’t.  My personal preference would be for this to be at the repo
> maintainers discretion.  I’m sure that sounds bad since I am the
> maintainer of nearly all of them, but I do want other people
> maintaining eventually and I’d still say the same thing even after it
> wasn’t me.
> 
> That said, I’m more concerned in building a community here, so I’m
> willing to submit to group-think if others feel one way or the other.

Maybe patches should be left up for review for at least 2 business days
if they're not a hot security fix or something equally drastic.

We probably need a way to identify the list of people who would likely
be interested in reviewing them as well.

Andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/openbmc/attachments/20171116/316cee22/attachment.sig>


More information about the openbmc mailing list