[PATCH 0/2] Improve NCSI driver logging
sam at mendozajonas.com
Tue Nov 7 11:14:24 AEDT 2017
On Tue, 2017-11-07 at 09:46 +1030, Joel Stanley wrote:
> On Mon, Nov 6, 2017 at 1:43 PM, Samuel Mendoza-Jonas
> <sam at mendozajonas.com> wrote:
> > The NCSI driver has next to no logging at all, with some of the only useful
> > logs actually coming from the ftgmac100 driver as link up/down messages.
> > Add a great deal more logging to the NCSI driver, tracking channel state and
> > selection, link events, and so on. Patch 1 has no functional changes, and
> > Patch 2 sends a Get-Parameters command during configuration to sanity check the
> > current channel.
> > A form of this will go upstream (the log levels probably need some tweaking),
> > but this iteration is being sent to OpenBMC to assist people currently
> > debugging a few network issues in the ftgmac100/NCSI/Broadcom area.
> Do you want this applied to the tree?
> I don't see a reason not to post it upstream (independently of me
> applying it) as is.
If you're happy to take it, yeah it will help debugging (or at least
laying blame) immensely.
Agreed about upstream, but I'll revise a few of the log levels down to
DEBUG/etc for that, and probably include it alongside some other fixes-
More information about the openbmc