[patch v11 1/4] drivers: jtag: Add JTAG core driver

Greg KH gregkh at linuxfoundation.org
Sat Nov 4 22:36:32 AEDT 2017


On Fri, Nov 03, 2017 at 05:54:06PM +0200, Oleksandr Shamray wrote:
> diff --git a/include/uapi/linux/jtag.h b/include/uapi/linux/jtag.h
> new file mode 100644
> index 0000000..0b25a83
> --- /dev/null
> +++ b/include/uapi/linux/jtag.h
> @@ -0,0 +1,117 @@
> +/*
> + * JTAG class driver
> + *
> + * Copyright (c) 2017 Mellanox Technologies. All rights reserved.
> + * Copyright (c) 2017 Oleksandr Shamray <oleksandrs at mellanox.com>
> + *
> + * Released under the GPLv2/BSD.
> + * SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause

Minor nit, this should go on the first line of the .h file now, to match
the rest of the kernel (just happened, not your fault.)

Also, uapi files are not just GPLv2, they have the userspace exception,
so this should just be:
	SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note
no need to add any BSD stuff to it at all.

thanks,

greg k-h


More information about the openbmc mailing list